Linux: use sandbox binary alongside chrome.

Linux: use sandbox binary alongside chrome.

This removes linux_sandbox_path and instead expects sandbox binary
to be in the same directory as chrome (or CHROME_DEVEL_SANDBOX to be
set).

This will be helpful for SxS support on Linux, where the sandbox path
would be different depending on channel.

BUG=38598
R=avi@chromium.org, jln@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215101

[jln (very slow on Chromium), 2013-07-30 02:03:59]

https://chromiumcodereview.appspot.com/20197003/diff/1/content/browser/browse...
File content/browser/browser_main_loop.cc (right):

https://chromiumcodereview.appspot.com/20197003/diff/1/content/browser/browse...
content/browser/browser_main_loop.cc:125: // In Chromium branded builds,
developers can set an environment variable to
The comment is misleading (not your fault).

Could you change it to something more clear, such as "In user-managed builds,
including development builds an environment variable ... is required ..."

https://chromiumcodereview.appspot.com/20197003/diff/1/content/browser/browse...
content/browser/browser_main_loop.cc:135: base::FilePath exe_dir;
I think Release Chrome will no longer start as root with this change (unless
CHROME_DEVEL_SANDBOX is set).

I'm not sure what the best solution is.

What do you think about the following:

- First, check if the file exe_dir.AppendASCII("chrome-sandbox"); exists.
- If that's the case, use this as sandbox_binary.
- Otherwise, if (stat()...getuid()) {}

This should work because it's very unlikely that a developer would have
chrome-sandbox in their directory (it should be called chrome_sandbox there).
And if they had it with the wrong permission, we would later crash with
LOG(FATAL) anyways (please give it a manual try).

[Paweł Hajdan Jr., 2013-07-30 19:12:33]

PTAL

https://codereview.chromium.org/20197003/diff/1/content/browser/browser_main_...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/20197003/diff/1/content/browser/browser_main_...
content/browser/browser_main_loop.cc:125: // In Chromium branded builds,
developers can set an environment variable to
On 2013/07/30 02:03:59, Julien Tinnes wrote:
> The comment is misleading (not your fault).
> 
> Could you change it to something more clear, such as "In user-managed builds,
> including development builds an environment variable ... is required ..."

Done.

https://codereview.chromium.org/20197003/diff/1/content/browser/browser_main_...
content/browser/browser_main_loop.cc:135: base::FilePath exe_dir;
On 2013/07/30 02:03:59, Julien Tinnes wrote:
> I think Release Chrome will no longer start as root with this change (unless
> CHROME_DEVEL_SANDBOX is set).
> 
> I'm not sure what the best solution is.
> 
> What do you think about the following:
> 
> - First, check if the file exe_dir.AppendASCII("chrome-sandbox"); exists.
> - If that's the case, use this as sandbox_binary.
> - Otherwise, if (stat()...getuid()) {}
> 
> This should work because it's very unlikely that a developer would have
> chrome-sandbox in their directory (it should be called chrome_sandbox there).
> And if they had it with the wrong permission, we would later crash with
> LOG(FATAL) anyways (please give it a manual try).

Done.

[jln (very slow on Chromium), 2013-07-30 19:24:35]

lgtm!

This is a nice improvement.

[Paweł Hajdan Jr., 2013-07-31 18:38:22]

Avi, could you just do content OWNERS review?

[Avi (use Gerrit), 2013-08-01 18:36:06]

lgtm

stampity stamp

[Paweł Hajdan Jr., 2013-08-01 20:38:23]

Committed patchset #2 manually as r215101.