Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2275063002: [Extensions] Don't generate a list for each generated schema (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Don't generate a list for each generated schema Currently, we generate a list of exactly one element for each generated schema. This simplifies it to just generate an object. BUG=641006 Committed: https://crrev.com/3b78360333968100cfee4ef50be21ee6f5d8d243 Cr-Commit-Position: refs/heads/master@{#414531}

Patch Set 1 #

Patch Set 2 : woot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -21 lines) Patch
M extensions/common/extension_api.cc View 1 3 chunks +8 lines, -18 lines 0 comments Download
M tools/json_schema_compiler/cpp_bundle_generator.py View 1 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Devlin
4 years, 3 months ago (2016-08-25 16:32:22 UTC) #11
lazyboy
lgtm
4 years, 3 months ago (2016-08-25 19:21:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2275063002/20001
4 years, 3 months ago (2016-08-25 20:42:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 20:48:38 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 20:51:54 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b78360333968100cfee4ef50be21ee6f5d8d243
Cr-Commit-Position: refs/heads/master@{#414531}

Powered by Google App Engine
This is Rietveld 408576698