Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2271813003:
[Extensions] Parse schema string directly into a v8 object (Closed)
|
Created:
4 years, 3 months ago by Devlin Modified:
4 years, 3 months ago CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@dc_prefix_schema_in_generation Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Extensions] Parse schema string directly into a v8 object
In the renderer, we need to parse the extension schema string and pass
it to JS in order to create our bindings. However, right now, we first
parse this into a DictionaryValue, and then convert it into a
v8::Object. However, now that we fully generate all the schema code, we
should be able to parse it directly from a string into a v8::Object.
BUG=640247
Committed: https://crrev.com/2fdf3d97334819323dc2f42e79fb9d897b069ec4
Cr-Commit-Position: refs/heads/master@{#414725}
Patch Set 1 : update #Patch Set 2 : Rebase #
Messages
Total messages: 27 (20 generated)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== funzies BUG= ========== to ========== [Extensions] Parse schema string directly into a v8 object In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 ==========
Patchset #1 (id:20001) has been deleted
rdevlin.cronin@chromium.org changed reviewers: + asargent@chromium.org
Antony, mind taking a look?
lgtm
rdevlin.cronin@chromium.org changed reviewers: + jochen@chromium.org
jochen, can you confirm that this v8 use isn't crazy in any way?
lgtm
The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rdevlin.cronin@chromium.org
The CQ bit was checked by rdevlin.cronin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org, asargent@chromium.org Link to the patchset: https://codereview.chromium.org/2271813003/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Parse schema string directly into a v8 object In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 ========== to ========== [Extensions] Parse schema string directly into a v8 object In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Extensions] Parse schema string directly into a v8 object In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 ========== to ========== [Extensions] Parse schema string directly into a v8 object In the renderer, we need to parse the extension schema string and pass it to JS in order to create our bindings. However, right now, we first parse this into a DictionaryValue, and then convert it into a v8::Object. However, now that we fully generate all the schema code, we should be able to parse it directly from a string into a v8::Object. BUG=640247 Committed: https://crrev.com/2fdf3d97334819323dc2f42e79fb9d897b069ec4 Cr-Commit-Position: refs/heads/master@{#414725} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2fdf3d97334819323dc2f42e79fb9d897b069ec4 Cr-Commit-Position: refs/heads/master@{#414725} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
