chrome/browser/ui/extensions/application_launch.cc - Issue 2274973003: Enable site engagement in incognito.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 2274973003: Enable site engagement in incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address_nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index 9a98e55f8c0951988246cbb865beff34e25a78a5..7262dfe127c876a8acad3e50d173cacb1ab1ab10 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -324,8 +324,7 @@ WebContents* OpenEnabledApplication(const AppLaunchParams& params) {

// Record the launch time in the site engagement service. A recent bookmark

// app launch will provide an engagement boost to the origin.

SiteEngagementService* service = SiteEngagementService::Get(params.profile);

- if (service)

- service->SetLastShortcutLaunchTime(url);

+ service->SetLastShortcutLaunchTime(url);

}

// Record v1 app launch. Platform app launch is recorded when dispatching