Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 2274973003: Enable site engagement in incognito. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address_nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service_unittest.cc
diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc
index db0920843f7d3693aa7ed74f2fdee356977c77f8..d89be640e807f44ed075c5e181ce491d0e3bdf1a 100644
--- a/chrome/browser/engagement/site_engagement_service_unittest.cc
+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc
@@ -1470,3 +1470,39 @@ TEST_F(SiteEngagementServiceTest, LastEngagementTime) {
EXPECT_EQ(later_in_day, last_engagement_time);
EXPECT_EQ(later_in_day, service->GetLastEngagementTime());
}
+
+TEST_F(SiteEngagementServiceTest, IncognitoEngagementService) {
+ SiteEngagementService* service = SiteEngagementService::Get(profile());
+ ASSERT_TRUE(service);
+
+ GURL url1("http://www.google.com/");
+ GURL url2("https://www.google.com/");
+ GURL url3("https://drive.google.com/");
+ GURL url4("https://maps.google.com/");
+
+ service->AddPoints(url1, 1);
+ service->AddPoints(url2, 2);
+
+ SiteEngagementService* incognito_service =
+ SiteEngagementService::Get(profile()->GetOffTheRecordProfile());
+ EXPECT_EQ(1, incognito_service->GetScore(url1));
+ EXPECT_EQ(2, incognito_service->GetScore(url2));
+ EXPECT_EQ(0, incognito_service->GetScore(url3));
+
+ incognito_service->AddPoints(url3, 1);
+ EXPECT_EQ(1, incognito_service->GetScore(url3));
+ EXPECT_EQ(0, service->GetScore(url3));
+
+ incognito_service->AddPoints(url2, 1);
+ EXPECT_EQ(3, incognito_service->GetScore(url2));
+ EXPECT_EQ(2, service->GetScore(url2));
+
+ service->AddPoints(url3, 2);
+ EXPECT_EQ(1, incognito_service->GetScore(url3));
+ EXPECT_EQ(2, service->GetScore(url3));
+
+ EXPECT_EQ(0, incognito_service->GetScore(url4));
+ service->AddPoints(url4, 2);
+ EXPECT_EQ(2, incognito_service->GetScore(url4));
+ EXPECT_EQ(2, service->GetScore(url4));
+}
« no previous file with comments | « chrome/browser/engagement/site_engagement_service_factory.cc ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698