Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2274763002: Use buildbucket to assess build failure. (Closed)

Created:
4 years, 3 months ago by RobertoCN
Modified:
4 years, 3 months ago
Reviewers:
eakuefner, dtu, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Use buildbucket to assess build failure. This removes the querying of buildbot json interface (which is deprecated) BUG=638599 R=prasadv,eakuefner,dtu Committed: https://chromium.googlesource.com/chromium/tools/build/+/436fca7b536c5c007936a4e535c7ad3de429c512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+761 lines, -242 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/example.py View 2 chunks +5 lines, -31 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json View 12 chunks +211 lines, -48 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 3 chunks +40 lines, -22 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 3 chunks +30 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 2 chunks +20 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/revision_state.py View 5 chunks +15 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 4 chunks +40 lines, -8 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 2 chunks +20 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 2 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
RobertoCN
4 years, 3 months ago (2016-08-23 22:23:09 UTC) #1
eakuefner
lgtm
4 years, 3 months ago (2016-08-23 22:51:06 UTC) #2
dtu
This is really great. lgtm
4 years, 3 months ago (2016-08-24 02:40:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274763002/1
4 years, 3 months ago (2016-08-24 05:20:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/436fca7b536c5c007936a4e535c7ad3de429c512
4 years, 3 months ago (2016-08-24 05:24:25 UTC) #7
prasadv
4 years, 3 months ago (2016-08-25 18:26:47 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2278233002/ by prasadv@chromium.org.

The reason for reverting is: Breaking Bisect and Perf try jobs.
Ref: crbug.com/640915.

Powered by Google App Engine
This is Rietveld 408576698