Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/example.py

Issue 2274763002: Use buildbucket to assess build failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/example.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/example.py b/scripts/slave/recipe_modules/auto_bisect/example.py
index fc65a1b41d385dcd3e888dd34c64ec2af4f618a7..892eb3a4a52029001f021d95c4f1fb4eab4c74f5 100644
--- a/scripts/slave/recipe_modules/auto_bisect/example.py
+++ b/scripts/slave/recipe_modules/auto_bisect/example.py
@@ -90,17 +90,9 @@ def GenTests(api):
failed_build_test += api.step_data('gsutil ls', retcode=1)
failed_build_test += api.step_data('gsutil ls (2)' , retcode=1)
failed_build_test += api.step_data('gsutil ls (3)' , retcode=1)
- failed_build_test += api.step_data(
- 'fetch builder state',
- api.raw_io.output(json.dumps({'cachedBuilds': ['2106']})))
- failed_build_test += api.step_data(
- 'fetch build details',
- api.raw_io.output(json.dumps({
- 'results': 2,
- 'properties': [('build_archive_url',
- ('gs://chrome-perf/Linux Builder/full-build-linux_'
- 'a6298e4afedbf2cd461755ea6f45b0ad64222222.zip'))]
- })))
+ failed_build_test += api.override_step_data(
+ 'buildbucket.get', stdout=api.json.output(
+ {'results':[{'build':{'status': 'COMPLETED', 'result': 'FAILED'}}]}))
yield failed_build_test
@@ -114,26 +106,8 @@ def GenTests(api):
delayed_build_test += api.step_data('gsutil ls (5)', retcode=1)
delayed_build_test += api.step_data('gsutil ls (6)', retcode=1)
delayed_build_test += api.step_data(
- 'fetch builder state',
- api.raw_io.output(json.dumps({'cachedBuilds': []})))
- delayed_build_test += api.step_data(
- 'fetch builder state (2)',
- api.raw_io.output(json.dumps({'cachedBuilds': ['2106']})))
- delayed_build_test += api.step_data(
- 'fetch build details',
- api.raw_io.output(json.dumps({
- 'properties': [('build_archive_url',
- ('gs://chrome-perf/Linux Builder/full-build-linux_'
- 'a6298e4afedbf2cd461755ea6f45b0ad64222222.zip'))]
- })))
- delayed_build_test += api.step_data(
- 'fetch build details (2)',
- api.raw_io.output(json.dumps({
- 'results': 2,
- 'properties': [('build_archive_url',
- ('gs://chrome-perf/Linux Builder/full-build-linux_'
- 'a6298e4afedbf2cd461755ea6f45b0ad64222222.zip'))]
- })))
+ 'buildbucket.get', stdout=api.json.output(
+ {'results':[{'build':{'status': 'PENDING'}}]}))
yield delayed_build_test
missing_metric_test = _make_test(
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698