Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2183)

Unified Diff: chrome/browser/resources/offline_pages/offline_internals.js

Issue 2274733002: [Offline pages] Add null pointer checks in offline internals code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incognito Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline/offline_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/offline_pages/offline_internals.js
diff --git a/chrome/browser/resources/offline_pages/offline_internals.js b/chrome/browser/resources/offline_pages/offline_internals.js
index 7e4c2b197f45ed333f8117ce601de51ae07dd96d..baa0d181feaf049c62c42c543222fd0c0d8cd627 100644
--- a/chrome/browser/resources/offline_pages/offline_internals.js
+++ b/chrome/browser/resources/offline_pages/offline_internals.js
@@ -195,6 +195,15 @@ cr.define('offlineInternals', function() {
$('request-status').textContent = enabled ? 'On' : 'Off';
}
+ var incognito = loadTimeData.getBoolean('isIncognito');
+ $('clear-all').disabled = incognito;
+ $('clear-selected').disabled = incognito;
+ $('log-model-on').disabled = incognito;
+ $('log-model-off').disabled = incognito;
+ $('log-request-on').disabled = incognito;
+ $('log-request-off').disabled = incognito;
+ $('refresh').disabled = incognito;
+
$('clear-all').onclick = deleteAllPages;
$('clear-selected').onclick = deleteSelectedPages;
$('refresh').onclick = refreshAll;
@@ -226,8 +235,8 @@ cr.define('offlineInternals', function() {
});
}
};
-
- refreshAll();
+ if (!incognito)
+ refreshAll();
}
// Return an object with all of the exports.
« no previous file with comments | « no previous file | chrome/browser/ui/webui/offline/offline_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698