chrome/browser/ui/webui/offline/offline_internals_ui.cc - Issue 2274733002: [Offline pages] Add null pointer checks in offline internals code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui.cc

Issue 2274733002: [Offline pages] Add null pointer checks in offline internals code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incognito Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/offline_pages/offline_internals.js ('k') | chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/offline/offline_internals_ui.cc

diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui.cc b/chrome/browser/ui/webui/offline/offline_internals_ui.cc

index 1d05ae8abb51b9e26cb6e6a63c937c6cf0062970..af76f693c1ab57317965012072ac47bf47f225e1 100644

--- a/chrome/browser/ui/webui/offline/offline_internals_ui.cc

+++ b/chrome/browser/ui/webui/offline/offline_internals_ui.cc

@@ -29,7 +29,10 @@ OfflineInternalsUI::OfflineInternalsUI(content::WebUI* web_ui)

IDR_OFFLINE_INTERNALS_BROWSER_PROXY_JS);

html_source->SetDefaultResource(IDR_OFFLINE_INTERNALS_HTML);

- content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), html_source);

+ Profile* profile = Profile::FromWebUI(web_ui);

+ html_source->AddBoolean("isIncognito", profile->IsOffTheRecord());

+ content::WebUIDataSource::Add(profile, html_source);

web_ui->AddMessageHandler(

new offline_internals::OfflineInternalsUIMessageHandler());