net/socket/buffered_write_stream_socket.h - Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/buffered_write_stream_socket.h

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/buffered_write_stream_socket.h

diff --git a/net/socket/buffered_write_stream_socket.h b/net/socket/buffered_write_stream_socket.h

index 803018eefe3578b44706276eb10eae63e0c083d5..8eb94f3efd03cfd4db293c7c6fd1bf592837215c 100644

--- a/net/socket/buffered_write_stream_socket.h

+++ b/net/socket/buffered_write_stream_socket.h

@@ -43,8 +43,8 @@ class NET_EXPORT_PRIVATE BufferedWriteStreamSocket : public StreamSocket {

const CompletionCallback& callback) OVERRIDE;

virtual int Write(IOBuffer* buf, int buf_len,

const CompletionCallback& callback) OVERRIDE;

- virtual bool SetReceiveBufferSize(int32 size) OVERRIDE;

- virtual bool SetSendBufferSize(int32 size) OVERRIDE;

+ virtual int SetReceiveBufferSize(int32 size) OVERRIDE;

+ virtual int SetSendBufferSize(int32 size) OVERRIDE;

// StreamSocket interface

virtual int Connect(const CompletionCallback& callback) OVERRIDE;

« jingle/glue/pseudotcp_adapter.cc ('K') | « net/quic/quic_stream_factory.cc ('k') | net/socket/buffered_write_stream_socket.cc » ('j') | remoting/protocol/channel_multiplexer.cc » ('J')