content/browser/renderer_host/p2p/socket_host_tcp.cc - Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_host_tcp.cc

Issue 227473008: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Original CL, as was submitted, and previously reverted Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/adb/android_usb_socket.cc ('k') | content/browser/renderer_host/p2p/socket_host_test_utils.h » ('j') | jingle/glue/pseudotcp_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_host_tcp.cc

diff --git a/content/browser/renderer_host/p2p/socket_host_tcp.cc b/content/browser/renderer_host/p2p/socket_host_tcp.cc

index e1900efad2ffa91eecb3931003f9ce86542169c7..e24aeb11e9fed04072fa84be5b43c6f972232203 100644

--- a/content/browser/renderer_host/p2p/socket_host_tcp.cc

+++ b/content/browser/renderer_host/p2p/socket_host_tcp.cc

@@ -412,9 +412,9 @@ bool P2PSocketHostTcpBase::SetOption(P2PSocketOption option, int value) {

DCHECK_EQ(STATE_OPEN, state_);

switch (option) {

case P2P_SOCKET_OPT_RCVBUF:

- return socket_->SetReceiveBufferSize(value);

+ return socket_->SetReceiveBufferSize(value) == net::OK;

case P2P_SOCKET_OPT_SNDBUF:

- return socket_->SetSendBufferSize(value);

+ return socket_->SetSendBufferSize(value) == net::OK;

case P2P_SOCKET_OPT_DSCP:

return false; // For TCP sockets DSCP setting is not available.

default: