Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2274663003: Pull getParams up to NewTabPageViewHolder. (Closed)

Created:
4 years, 4 months ago by Michael van Ouwerkerk
Modified:
4 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@9patches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull getParams up to NewTabPageViewHolder. Committed: https://crrev.com/9bd22764213a8315e62584b8a6a306db0cd0f12a Cr-Commit-Position: refs/heads/master@{#414683}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 4 months ago (2016-08-24 17:06:13 UTC) #3
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-24 17:13:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274663003/1
4 years, 4 months ago (2016-08-24 17:16:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/129064)
4 years, 3 months ago (2016-08-24 20:22:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274663003/20001
4 years, 3 months ago (2016-08-26 10:30:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 11:08:17 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 11:10:42 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bd22764213a8315e62584b8a6a306db0cd0f12a
Cr-Commit-Position: refs/heads/master@{#414683}

Powered by Google App Engine
This is Rietveld 408576698