chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2274663003: Pull getParams up to NewTabPageViewHolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2274663003: Pull getParams up to NewTabPageViewHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@9patches

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index 848cb53628b6514b6693a4f10035e06fad3215f7..c1d1a7c38a650ced72767f229ac5b6aa258710f1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -269,10 +269,6 @@ public class CardViewHolder extends NewTabPageViewHolder {

return LayoutInflater.from(parent.getContext()).inflate(resourceId, parent, false);

}

- private RecyclerView.LayoutParams getParams() {

- return (RecyclerView.LayoutParams) itemView.getLayoutParams();

- }

/**

* Animates the card being swiped to the right as if the user had dismissed it. You must check

* {@link #isDismissable()} before calling.

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java » ('j') | no next file with comments »