[layoutng] Correctly resolve indefinite percentages

[layoutng] Correctly resolve indefinite percentages

R=ikilpatrick@chromium.org,eae@chromium.org
BUG=635619
Committed: https://crrev.com/36e71623779494dcdec9c1a5c4bbe369b70ffe21
Cr-Commit-Position: refs/heads/master@{#414103}

[cbiesinger, 2016-08-23 15:58:40]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 15:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 16:34:31]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cbiesinger, 2016-08-23 16:37:38]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 16:38:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-23 16:50:57]

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:24:
DCHECK_NE(constraintSpace.ContainerSize().inlineSize, LayoutUnit(-1));
Can the length ever go negative? If not change this check if it's is more than
or equal to zero.

If it can then we cannot use -1 as infinite and instead need to use
LayoutUnit::max

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:54:
constraintSpace.ContainerSize().blockSize == LayoutUnit(-1))
We might want to use a constant for infinite to improve readability/

[commit-bot: I haz the power, 2016-08-23 18:43:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:43:28]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-08-23 19:37:03]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-08-23 19:37:19]

PTAL!

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc (right):

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:24:
DCHECK_NE(constraintSpace.ContainerSize().inlineSize, LayoutUnit(-1));
On 2016/08/23 16:50:56, eae wrote:
> Can the length ever go negative? If not change this check if it's is more than
> or equal to zero.
> 
> If it can then we cannot use -1 as infinite and instead need to use
> LayoutUnit::max

Done. I don't think size can ever go negative.

https://codereview.chromium.org/2274593002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc:54:
constraintSpace.ContainerSize().blockSize == LayoutUnit(-1))
On 2016/08/23 16:50:57, eae wrote:
> We might want to use a constant for infinite to improve readability/

OK. Adding NGSizeIndefinite. Using a #define to avoid static initializers.

[commit-bot: I haz the power, 2016-08-23 19:37:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 21:47:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 21:47:38]

Dry run: This issue passed the CQ dry run.

[eae, 2016-08-24 17:50:25]

LGTM

[cbiesinger, 2016-08-24 17:54:00]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:54:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 18:00:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-24 18:03:19]

Description was changed from

==========
[layoutng] Correctly resolve indefinite percentages

R=ikilpatrick@chromium.org,eae@chromium.org
BUG=635619
==========

to

==========
[layoutng] Correctly resolve indefinite percentages

R=ikilpatrick@chromium.org,eae@chromium.org
BUG=635619

Committed: https://crrev.com/36e71623779494dcdec9c1a5c4bbe369b70ffe21
Cr-Commit-Position: refs/heads/master@{#414103}
==========

[commit-bot: I haz the power, 2016-08-24 18:03:20]

Patchset 3 (id:??) landed as
https://crrev.com/36e71623779494dcdec9c1a5c4bbe369b70ffe21
Cr-Commit-Position: refs/heads/master@{#414103}