third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2274593002: [layoutng] Correctly resolve indefinite percentages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2274593002: [layoutng] Correctly resolve indefinite percentages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: NGSizeIndefinite Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 6d2432b78135389d847d481832eec6f09fcb11b0..36530aaa99e1dc09aae6ff7f97019f254b202523 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -7,6 +7,7 @@

#include "core/layout/ng/ng_box_iterator.h"

#include "core/layout/ng/ng_constraint_space.h"

#include "core/layout/ng/ng_fragment.h"

+#include "core/layout/ng/ng_length_utils.h"

#include "core/style/ComputedStyle.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -26,7 +27,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, FixedSize) {

NGLogicalSize container_size;

container_size.inlineSize = LayoutUnit(100);

- container_size.blockSize = LayoutUnit(-1);

+ container_size.blockSize = NGSizeIndefinite;

NGConstraintSpace space(container_size);

NGBlockLayoutAlgorithm algorithm(style_, NGBoxIterator(NGBox()));

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_length_utils.h » ('j') | no next file with comments »