Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2274573008: Open offline page instead of download home when clicking OPEN button on snackbar (Closed)

Created:
4 years, 3 months ago by qinmin
Modified:
4 years, 3 months ago
Reviewers:
gone, fgorski
CC:
chromium-reviews, asanka, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Open offline page instead of download home when clicking OPEN button on snackbar When download snackbar shows up, clicking the open button will open download home for offline page. This CL corrects that behavior so that the corresponding offline page will be opened. BUG=641304 Committed: https://crrev.com/c17248a3ba1ac0e454b7b59a35d613a4cdf8e532 Cr-Commit-Position: refs/heads/master@{#414760}

Patch Set 1 #

Patch Set 2 : rebase #

Messages

Total messages: 17 (9 generated)
qinmin
PTAL
4 years, 3 months ago (2016-08-25 22:44:32 UTC) #2
fgorski
lgtm
4 years, 3 months ago (2016-08-25 22:49:00 UTC) #3
fgorski
On 2016/08/25 22:49:00, fgorski wrote: > lgtm Min, please update the bug number to 641262
4 years, 3 months ago (2016-08-26 16:24:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274573008/1
4 years, 3 months ago (2016-08-26 16:47:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/59175) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-08-26 16:50:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274573008/20001
4 years, 3 months ago (2016-08-26 17:32:31 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-26 18:45:36 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 19:16:18 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c17248a3ba1ac0e454b7b59a35d613a4cdf8e532
Cr-Commit-Position: refs/heads/master@{#414760}

Powered by Google App Engine
This is Rietveld 408576698