Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5035)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java

Issue 2274573008: Open offline page instead of download home when clicking OPEN button on snackbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
index f425895c54b7182df7d41f53a956437dadc8da3a..2d5f7d037fcc7122d3584f7f83029c0f9f7db292 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSnackbarController.java
@@ -10,6 +10,7 @@ import android.content.Context;
import org.chromium.base.ApplicationStatus;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.offlinepages.downloads.OfflinePageDownloadBridge;
import org.chromium.chrome.browser.snackbar.Snackbar;
import org.chromium.chrome.browser.snackbar.SnackbarManager;
@@ -44,7 +45,11 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
DownloadManagerService.openDownloadsPage(mContext);
return;
}
- ActionDataInfo download = (ActionDataInfo) actionData;
+ final ActionDataInfo download = (ActionDataInfo) actionData;
+ if (download.downloadInfo.isOfflinePage()) {
+ OfflinePageDownloadBridge.openDownloadedPage(download.downloadInfo.getDownloadGuid());
+ return;
+ }
DownloadManagerService manager = DownloadManagerService.getDownloadManagerService(mContext);
manager.openDownloadedContent(download.systemDownloadId);
if (download.notificationId != INVALID_NOTIFICATION_ID) {
@@ -76,7 +81,7 @@ public class DownloadSnackbarController implements SnackbarManager.SnackbarContr
// TODO(qinmin): Coalesce snackbars if multiple downloads finish at the same time.
snackbar.setDuration(SNACKBAR_DURATION_IN_MILLISECONDS).setSingleLine(false);
ActionDataInfo info = null;
- if (canBeResolved) {
+ if (canBeResolved || downloadInfo.isOfflinePage()) {
info = new ActionDataInfo(downloadInfo, notificationId, downloadId);
}
// Show downloads app if the download cannot be resolved to any activity.

Powered by Google App Engine
This is Rietveld 408576698