Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2274463002: [Typed OM] Add CSSValue -> CSSNumberValue conversion (Closed)

Created:
4 years, 4 months ago by meade_UTC10
Modified:
4 years, 4 months ago
Reviewers:
Timothy Loh, rjwright
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Typed OM] Add CSSValue -> CSSNumberValue conversion This allows retrieving of CSSNumberValue typed properties from the StylePropertyMaps, but does not allow setting. BUG=545318 Committed: https://crrev.com/3da351bc3124254baf2c705989e35d51b07fad96 Cr-Commit-Position: refs/heads/master@{#413978}

Patch Set 1 #

Patch Set 2 : Add list test #

Patch Set 3 : Remove setting altogether #

Patch Set 4 : Add test for computed style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -38 lines) Patch
A third_party/WebKit/LayoutTests/typedcssom/computedstyle/numbers.html View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/inlinestyle/numbers.html View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 3 chunks +42 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 2 chunks +46 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
meade_UTC10
PTAL
4 years, 4 months ago (2016-08-23 22:10:05 UTC) #13
Timothy Loh
lgtm typo in description "StyleProprtyMaps"
4 years, 4 months ago (2016-08-24 02:10:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274463002/60001
4 years, 4 months ago (2016-08-24 03:56:46 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-24 04:37:33 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 04:40:40 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3da351bc3124254baf2c705989e35d51b07fad96
Cr-Commit-Position: refs/heads/master@{#413978}

Powered by Google App Engine
This is Rietveld 408576698