Add PlatformScreenDelegate and start implementation.

Add PlatformScreenDelegate and start implementation.

There is currently a single callback provided to PlatformScreen for when
new displays are added. We need to be able to notify not only when new
displays are added but also when displays are modified or removed.
Instead of having three callbacks, the PlatformScreenDelegate interface
is added.

The ui::ws::DisplayManager class implements PlatformScreenDelegate. This
is ultimately the class that needs to know about changes to displays so
it can update root windows accordingly.

There are some changes to ownership and constructor parameters to
facilitate having DisplayManager implement PlatformScreenDelegate. The
WindowServer instance is passed into DisplayManager, as it doesn't make
sense that Display objects owned by DisplayManager are allowed to know
about WindowServer but DisplayManager is not. The DisplayManagerDelegate
interface is simplified and changed to UserDisplayManagerDelegate as
it's no longer needed for DisplayManager.

The instantiation of SurfaceState is moved from Service to WindowServer.
There is no need to have Service know about SurfaceState anymore. Also,
SurfaceState will be moving to the GPU processes regardless.

BUG=641012
Committed: https://crrev.com/5ea85f775041eb6ccb4813bdf91e1672f829c577
Cr-Commit-Position: refs/heads/master@{#414710}

[kylechar, 2016-08-25 16:58:12]

Patchset #2 (id:20001) has been deleted

[kylechar, 2016-08-25 17:00:45]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-08-25 19:18:43]

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
File services/ui/display/platform_screen.h (right):

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
services/ui/display/platform_screen.h:22: class PlatformScreenDelegate {
It's common chrome practice (and mentioned in style guide) to put interfaces
like this in their own class. Also, make the destructor protected to reinforce
delegate isn't owned by screen.

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
services/ui/display/platform_screen.h:51: virtual void
ConfigureDisplays(PlatformScreenDelegate* delegate) = 0;
Is there a reason we need both Init and Configure? Can't Init do the config? Or
even have Create() do all this (including taking the delegate).

https://codereview.chromium.org/2274353003/diff/40001/services/ui/ws/window_s...
File services/ui/ws/window_server_delegate.h (right):

https://codereview.chromium.org/2274353003/diff/40001/services/ui/ws/window_s...
services/ui/ws/window_server_delegate.h:50: virtual void UpdateTouchTransforms()
= 0;
Add a comment as to what this is for.

[kylechar, 2016-08-25 20:26:02]

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
File services/ui/display/platform_screen.h (right):

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
services/ui/display/platform_screen.h:22: class PlatformScreenDelegate {
On 2016/08/25 19:18:43, sky wrote:
> It's common chrome practice (and mentioned in style guide) to put interfaces
> like this in their own class. Also, make the destructor protected to reinforce
> delegate isn't owned by screen.

Done.

https://codereview.chromium.org/2274353003/diff/40001/services/ui/display/pla...
services/ui/display/platform_screen.h:51: virtual void
ConfigureDisplays(PlatformScreenDelegate* delegate) = 0;
On 2016/08/25 19:18:43, sky wrote:
> Is there a reason we need both Init and Configure? Can't Init do the config?
Or
> even have Create() do all this (including taking the delegate).

Yeah, that definitely works. I've merged Init() and ConfigureDisplays() into a
single method. 

We can't have Create perform all of the initialization right now because we wait
for WindowServer to get setup before we start display configuration.

https://codereview.chromium.org/2274353003/diff/40001/services/ui/ws/window_s...
File services/ui/ws/window_server_delegate.h (right):

https://codereview.chromium.org/2274353003/diff/40001/services/ui/ws/window_s...
services/ui/ws/window_server_delegate.h:50: virtual void UpdateTouchTransforms()
= 0;
On 2016/08/25 19:18:43, sky wrote:
> Add a comment as to what this is for.

Done.

[sky, 2016-08-25 23:40:32]

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
File services/ui/display/platform_screen.h (right):

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
services/ui/display/platform_screen.h:28: virtual void
InitialConfig(PlatformScreenDelegate* delegate) = 0;
optional: I think Init() is a better are more well understood name for what this
does.

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
File services/ui/display/platform_screen_delegate.h (right):

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
services/ui/display/platform_screen_delegate.h:28: const gfx::Rect& bounds) = 0;
Please clarify what the units are here. DIP or pixel.

[sky, 2016-08-25 23:40:40]

LGTM

[kylechar, 2016-08-26 13:21:19]

Thanks!

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
File services/ui/display/platform_screen.h (right):

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
services/ui/display/platform_screen.h:28: virtual void
InitialConfig(PlatformScreenDelegate* delegate) = 0;
On 2016/08/25 23:40:31, sky wrote:
> optional: I think Init() is a better are more well understood name for what
this
> does.

Done.

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
File services/ui/display/platform_screen_delegate.h (right):

https://codereview.chromium.org/2274353003/diff/60001/services/ui/display/pla...
services/ui/display/platform_screen_delegate.h:28: const gfx::Rect& bounds) = 0;
On 2016/08/25 23:40:31, sky wrote:
> Please clarify what the units are here. DIP or pixel.

Done.

[kylechar, 2016-08-26 13:27:28]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-08-26 13:27:29]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2274353003/#ps80001
(title: "More fixes for comments.")

[commit-bot: I haz the power, 2016-08-26 13:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 14:48:35]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-08-26 14:50:46]

Description was changed from

==========
Add PlatformScreenDelegate and start implementation.

There is currently a single callback provided to PlatformScreen for when
new displays are added. We need to be able to notify not only when new
displays are added but also when displays are modified or removed.
Instead of having three callbacks, the PlatformScreenDelegate interface
is added.

The ui::ws::DisplayManager class implements PlatformScreenDelegate. This
is ultimately the class that needs to know about changes to displays so
it can update root windows accordingly.

There are some changes to ownership and constructor parameters to
facilitate having DisplayManager implement PlatformScreenDelegate. The
WindowServer instance is passed into DisplayManager, as it doesn't make
sense that Display objects owned by DisplayManager are allowed to know
about WindowServer but DisplayManager is not. The DisplayManagerDelegate
interface is simplified and changed to UserDisplayManagerDelegate as
it's no longer needed for DisplayManager.

The instantiation of SurfaceState is moved from Service to WindowServer.
There is no need to have Service know about SurfaceState anymore. Also,
SurfaceState will be moving to the GPU processes regardless.

BUG=641012
==========

to

==========
Add PlatformScreenDelegate and start implementation.

There is currently a single callback provided to PlatformScreen for when
new displays are added. We need to be able to notify not only when new
displays are added but also when displays are modified or removed.
Instead of having three callbacks, the PlatformScreenDelegate interface
is added.

The ui::ws::DisplayManager class implements PlatformScreenDelegate. This
is ultimately the class that needs to know about changes to displays so
it can update root windows accordingly.

There are some changes to ownership and constructor parameters to
facilitate having DisplayManager implement PlatformScreenDelegate. The
WindowServer instance is passed into DisplayManager, as it doesn't make
sense that Display objects owned by DisplayManager are allowed to know
about WindowServer but DisplayManager is not. The DisplayManagerDelegate
interface is simplified and changed to UserDisplayManagerDelegate as
it's no longer needed for DisplayManager.

The instantiation of SurfaceState is moved from Service to WindowServer.
There is no need to have Service know about SurfaceState anymore. Also,
SurfaceState will be moving to the GPU processes regardless.

BUG=641012

Committed: https://crrev.com/5ea85f775041eb6ccb4813bdf91e1672f829c577
Cr-Commit-Position: refs/heads/master@{#414710}
==========

[commit-bot: I haz the power, 2016-08-26 14:50:47]

Patchset 4 (id:??) landed as
https://crrev.com/5ea85f775041eb6ccb4813bdf91e1672f829c577
Cr-Commit-Position: refs/heads/master@{#414710}