Enable the WebUSB Origin Trial.

Enable the WebUSB Origin Trial.

This patch enables the WebUSB interfaces if a site has an Origin Trial
key for the feature "WebUSB". They can still also be enabled by passing
the --enable-experimental-web-platform-features flag.

BUG=492204
Committed: https://crrev.com/2fe96ea775a73ad5dcc05105f57be096d302baa2
Cr-Commit-Position: refs/heads/master@{#414591}

[Reilly Grant (use Gerrit), 2016-08-24 21:24:18]

reillyg@chromium.org changed reviewers:
+ jochen@chromium.org

[Reilly Grant (use Gerrit), 2016-08-24 21:24:19]

Please take a look. This re-lands https://codereview.chromium.org/1671553004
with updated for modern Origin Trials.

[haraken, 2016-08-24 23:54:05]

bindings/ LGTM

[Reilly Grant (use Gerrit), 2016-08-25 15:16:27]

reillyg@chromium.org changed reviewers:
+ haraken@chromium.org, thestig@chromium.org
- jochen@chromium.org

[Reilly Grant (use Gerrit), 2016-08-25 15:17:05]

thestig@, please take a look.

[Lei Zhang, 2016-08-25 15:22:38]

Since you are removing some checks for
--enable-experimental-web-platform-features, where do we still check for that
flag to force-enable the feature? Assuming I read the CL description correctly.
Also, where do we check for the origin trial key?

[Reilly Grant (use Gerrit), 2016-08-25 17:17:19]

I've verified that both origin trial keys and
--enable-experimental-web-platform-features enables the API and it is disabled
without them.

On 2016/08/25 at 15:22:38, thestig wrote:
> Since you are removing some checks for
--enable-experimental-web-platform-features, where do we still check for that
flag to force-enable the feature? Assuming I read the CL description correctly.

When --enable-experimental-web-platform-features is set
RuntimeEnabledFeatures::setExperimentalFeaturesEnabled() will enable WebUSB
manually.

> Also, where do we check for the origin trial key?

In V8Binding.cpp and V8BindingForModules.cpp.

[Lei Zhang, 2016-08-25 17:24:03]

lgtm, thanks for checking.

[Reilly Grant (use Gerrit), 2016-08-25 17:42:28]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:43:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 17:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:52:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Reilly Grant (use Gerrit), 2016-08-25 19:13:36]

reillyg@chromium.org changed reviewers:
+ dglazkov@chromium.org

[Reilly Grant (use Gerrit), 2016-08-25 19:13:36]

dglazkov@ for API owners approval.

[Reilly Grant (use Gerrit), 2016-08-25 19:48:13]

On 2016/08/25 at 19:13:36, Reilly Grant wrote:
> dglazkov@ for API owners approval.

Never mind. Updating global-interface-listing-expected.txt is unnecessary.

[Reilly Grant (use Gerrit), 2016-08-25 19:48:24]

reillyg@chromium.org changed reviewers:
- dglazkov@chromium.org

[Reilly Grant (use Gerrit), 2016-08-25 19:49:28]

Revert update to global-interface-listing-expected.txt.

[Reilly Grant (use Gerrit), 2016-08-25 19:50:43]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-08-25 19:50:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2274303002/#ps20001
(title: "Revert update to global-interface-listing-expected.txt.")

[commit-bot: I haz the power, 2016-08-25 19:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 00:17:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-26 00:30:59]

Description was changed from

==========
Enable the WebUSB Origin Trial.

This patch enables the WebUSB interfaces if a site has an Origin Trial
key for the feature "WebUSB". They can still also be enabled by passing
the --enable-experimental-web-platform-features flag.

BUG=492204
==========

to

==========
Enable the WebUSB Origin Trial.

This patch enables the WebUSB interfaces if a site has an Origin Trial
key for the feature "WebUSB". They can still also be enabled by passing
the --enable-experimental-web-platform-features flag.

BUG=492204

Committed: https://crrev.com/2fe96ea775a73ad5dcc05105f57be096d302baa2
Cr-Commit-Position: refs/heads/master@{#414591}
==========

[commit-bot: I haz the power, 2016-08-26 00:31:00]

Patchset 2 (id:??) landed as
https://crrev.com/2fe96ea775a73ad5dcc05105f57be096d302baa2
Cr-Commit-Position: refs/heads/master@{#414591}