Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/installable/installable_manager_browsertest.cc

Issue 2274273002: Remove redundant SkBitmap::drawsNothing() check in AddToHomescreenDataFetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_dialog_detector0 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/installable/installable_manager_browsertest.cc
diff --git a/chrome/browser/installable/installable_manager_browsertest.cc b/chrome/browser/installable/installable_manager_browsertest.cc
index 78c578319a30e4db50966b3f38e6118fa1234b6b..9bfb62bac4ca3c7e5da4d9745291aaa6d4874fed 100644
--- a/chrome/browser/installable/installable_manager_browsertest.cc
+++ b/chrome/browser/installable/installable_manager_browsertest.cc
@@ -515,6 +515,26 @@ IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest,
}
IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest,
+ CheckManifestCorruptedIcon) {
+ // Verify that the returned InstallableData::icon is null if the web manifest
+ // points to a corrupt icon.
+ base::RunLoop run_loop;
+ std::unique_ptr<CallbackTester> tester(
+ new CallbackTester(run_loop.QuitClosure()));
+
+ NavigateAndRunInstallableManager(tester.get(), GetIconParams(),
+ "/banners/manifest_bad_icon_test_page.html");
+ run_loop.Run();
+
+ EXPECT_FALSE(tester->manifest().IsEmpty());
+ EXPECT_FALSE(tester->manifest_url().is_empty());
+ EXPECT_TRUE(tester->icon_url().is_empty());
+ EXPECT_EQ(nullptr, tester->icon());
+ EXPECT_FALSE(tester->is_installable());
+ EXPECT_EQ(NO_ICON_AVAILABLE, tester->error_code());
+}
+
+IN_PROC_BROWSER_TEST_F(InstallableManagerBrowserTest,
CheckChangeInIconDimensions) {
// Verify that a follow-up request for an icon with a different size works.
{
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc ('k') | chrome/test/data/banners/bad_icon.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698