Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

The ChromeBrowserProvider implementations should now also own their
ChromeIdentityService and allow it to be overriden. This is necessary
so that FakeChromeIdentityService can be used with the real
ChromeBrowserProvider in integration tests.

Also upstream some methods in ChromeIdentityService.

BUG=640623
Committed: https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51
Cr-Commit-Position: refs/heads/master@{#415011}

[bzanotti, 2016-08-24 15:28:05]

bzanotti@chromium.org changed reviewers:
+ rohitrao@chromium.org

[bzanotti, 2016-08-24 15:28:05]

Please take a look.

[bzanotti, 2016-08-29 13:34:49]

On 2016/08/24 15:28:05, bzanotti wrote:
> Please take a look.

Ping, this is blocking the setup for EarlGrey tests using sign-in.

[rohitrao (ping after 24h), 2016-08-29 13:46:14]

Does the setter need to be part of the public provider interface?  Could you
instead add it as a non-virtual method on the ChromeBrowserProviderImpl?

[rohitrao (ping after 24h), 2016-08-29 14:16:36]

LGTM because I don't have any better suggestions that satisfy the following
constraints:
1) Chromium code needs to be able to override/inject a fake identityservice,
even one that is set by internal code.
2) Chromium code needs to be able to call a single method that returns the
proper service, either an injected fake or the real service.

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/chrome_browser_provider.h (right):

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/chrome_browser_provider.h:84: virtual void
SetChromeIdentityService(
Perhaps calls this SetChromeIdentityServiceForTesting(), because we don't want
anyone using it for realz.

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:28:
chrome_identity_service_.swap(service);
Why swap() instead of reset()?

[bzanotti, 2016-08-29 14:31:47]

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/chrome_browser_provider.h (right):

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/chrome_browser_provider.h:84: virtual void
SetChromeIdentityService(
On 2016/08/29 14:16:36, rohitrao wrote:
> Perhaps calls this SetChromeIdentityServiceForTesting(), because we don't want
> anyone using it for realz.

Done.

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/test_chrome_browser_provider.mm (right):

https://codereview.chromium.org/2274163002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/test_chrome_browser_provider.mm:28:
chrome_identity_service_.swap(service);
On 2016/08/29 14:16:36, rohitrao wrote:
> Why swap() instead of reset()?

AFAIK, reset() cannot be used with two unique_ptr. Here, service is a unique_ptr
as well (to show that SetChromeIdentityService will take over the ownership).

[bzanotti, 2016-08-29 14:32:03]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2016-08-29 14:32:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2274163002/#ps20001
(title: "Rename method used for testing")

[commit-bot: I haz the power, 2016-08-29 14:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 15:15:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-29 15:17:22]

Description was changed from

==========
Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

The ChromeBrowserProvider implementations should now also own their
ChromeIdentityService and allow it to be overriden. This is necessary
so that FakeChromeIdentityService can be used with the real
ChromeBrowserProvider in integration tests.

Also upstream some methods in ChromeIdentityService.

BUG=640623
==========

to

==========
Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

The ChromeBrowserProvider implementations should now also own their
ChromeIdentityService and allow it to be overriden. This is necessary
so that FakeChromeIdentityService can be used with the real
ChromeBrowserProvider in integration tests.

Also upstream some methods in ChromeIdentityService.

BUG=640623

Committed: https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51
Cr-Commit-Position: refs/heads/master@{#415011}
==========

[commit-bot: I haz the power, 2016-08-29 15:17:23]

Patchset 2 (id:??) landed as
https://crrev.com/be21c8594be847e6520d41b4384b0fcd90e88c51
Cr-Commit-Position: refs/heads/master@{#415011}