ios/public/provider/chrome/browser/signin/chrome_identity_service.mm - Issue 2274163002: Allow ChromeIdentityService in ChromeBrowserProvider to be overriden.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/provider/chrome/browser/signin/chrome_identity_service.mm

Issue 2274163002: Allow ChromeIdentityService in ChromeBrowserProvider to be overriden. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename method used for testing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/public/provider/chrome/browser/signin/chrome_identity_service.h ('k') | ios/public/provider/chrome/browser/test_chrome_browser_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/public/provider/chrome/browser/signin/chrome_identity_service.mm

diff --git a/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm b/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm

index 833d9dd08e1dcd0ac59354eceaae4ada63fd38a8..f34f6005805f064828e20a7181f7a47a4c01806d 100644

--- a/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm

+++ b/ios/public/provider/chrome/browser/signin/chrome_identity_service.mm

@@ -15,6 +15,14 @@ ChromeIdentityService::~ChromeIdentityService() {

OnChromeIdentityServiceWillBeDestroyed());

}

+void ChromeIdentityService::DismissDialogs() {}

+bool ChromeIdentityService::HandleApplicationOpenURL(UIApplication* application,

+ NSURL* url,

+ NSDictionary* options) {

+ return false;

base::scoped_nsobject<UINavigationController>

ChromeIdentityService::NewAccountDetails(

ChromeIdentity* identity,