Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2274153002: SkPDF: vertical writing: draw nothing (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/pdf/SkPDFDevice.cpp View 4 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hal.canary
PTAL
4 years, 3 months ago (2016-08-24 15:23:31 UTC) #4
bungeman-skia
lgtm
4 years, 3 months ago (2016-08-24 15:32:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2274153002/1
4 years, 3 months ago (2016-08-24 15:43:07 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 16:21:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ea17dfe40b04fa476008af67984b7a41dc5243f7

Powered by Google App Engine
This is Rietveld 408576698