SkPDF: vertical writing: draw nothing

src/pdf/SkPDFDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPDFDevice.h"
 #include "SkAnnotationKeys.h"
 #include "SkBitmapDevice.h"
@@ skipping 1061 matching lines @@
 void SkPDFDevice::internalDrawText(
         const SkDraw& d, const void* sourceText, size_t sourceByteCount,
         const SkScalar pos[], SkTextBlob::GlyphPositioning positioning,
         SkPoint offset, const SkPaint& srcPaint) {
     NOT_IMPLEMENTED(srcPaint.getMaskFilter() != nullptr, false);
     if (srcPaint.getMaskFilter() != nullptr) {
         // Don't pretend we support drawing MaskFilters, it makes for artifacts
         // making text unreadable (e.g. same text twice when using CSS shadows).
         return;
     }
+    NOT_IMPLEMENTED(srcPaint.isVerticalText(), false);
+    if (srcPaint.isVerticalText()) {
+        // Don't pretend we support drawing vertical text.  It is not
+        // clear to me how to switch to "vertical writing" mode in PDF.
+        // Currently neither Chromium or Android set this flag.
+        // https://bug.skia.org/5665
+        return;
+    }
     SkPaint paint = calculate_text_paint(srcPaint);
     replace_srcmode_on_opaque_paint(&paint);
     if (!paint.getTypeface()) {
         paint.setTypeface(SkTypeface::MakeDefault());
     }
     SkTypeface* typeface = paint.getTypeface();
     if (!typeface) {
         SkDebugf("SkPDF: SkTypeface::MakeDefault() returned nullptr.\n");
         return;
     }
@@ skipping 27 matching lines @@
             glyphs[i] = SkTMin(maxGlyphID, glyphs[i]);
         }
     } else {
         paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
     }
 
     bool defaultPositioning = (positioning == SkTextBlob::kDefault_Positioning);
     SkAutoGlyphCache glyphCache(paint, nullptr, nullptr);
 
     SkPaint::Align alignment = paint.getTextAlign();
-    bool verticalText = paint.isVerticalText();
     if (defaultPositioning && alignment != SkPaint::kLeft_Align) {
         SkScalar advance{0};
         for (int i = 0; i < glyphCount; ++i) {
             advance += glyphCache->getGlyphIDAdvance(glyphs[i]).fAdvanceX;
         }
         SkScalar m = alignment == SkPaint::kCenter_Align
             ? 0.5f * advance : advance;
-        offset -= verticalText ? SkPoint{0, m} : SkPoint{m, 0};
+        offset -= SkPoint{m, 0};
     }
     ScopedContentEntry content(this, d, paint, true);
     if (!content.entry()) {
         return;
     }
     SkDynamicMemoryWStream* out = &content.entry()->fContent;
     out->writeText("BT\n");
     if (!this->updateFont(paint, glyphs[0], content.entry())) {
         SkDebugf("SkPDF: Font error.");
         out->writeText("ET\n%SkPDF: Font error.\n");
@@ skipping 45 matching lines @@
         } else {
             while (stretch-- > 0) {
                 SkScalar advance = glyphCache->getGlyphIDAdvance(*glyphs).fAdvanceX;
                 SkScalar x = *pos++;
                 // evaluate x and y in order!
                 SkScalar y = SkTextBlob::kFull_Positioning == positioning ? *pos++ : 0;
                 SkPoint xy{x, y};
                 if (alignment != SkPaint::kLeft_Align) {
                     SkScalar m = alignment == SkPaint::kCenter_Align
                         ? 0.5f * advance : advance;
-                    xy -= verticalText ? SkPoint{0, m} : SkPoint{m, 0};
+                    xy -= SkPoint{m, 0};
                 }
                 (void)font->glyphsToPDFFontEncoding(glyphs, 1);
                 glyphPositioner.writeGlyph(xy.x(), xy.y(), advance, *glyphs);
                 ++glyphs;
             }
         }
     }
     glyphPositioner.flush();
     out->writeText("ET\n");
 }
@@ skipping 923 matching lines @@
 }
 
 sk_sp<SkSpecialImage> SkPDFDevice::makeSpecial(const SkImage* image) {
     return SkSpecialImage::MakeFromImage(SkIRect::MakeWH(image->width(), image->height()),
                                          image->makeNonTextureImage());
 }
 
 sk_sp<SkSpecialImage> SkPDFDevice::snapSpecial() {
     return nullptr;
 }