Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227413011: Remove old texture path in TextureLayer (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Remove old texture path in TextureLayer This lets us also remove LayerTreeHost::AcquireLayerTextures and related scheduler things. BUG=337922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262878

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -1488 lines) Patch
M cc/layers/texture_layer.h View 5 chunks +3 lines, -20 lines 0 comments Download
M cc/layers/texture_layer.cc View 7 chunks +20 lines, -61 lines 0 comments Download
M cc/layers/texture_layer_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/texture_layer_impl.h View 1 4 chunks +3 lines, -10 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 1 8 chunks +57 lines, -102 lines 0 comments Download
M cc/layers/texture_layer_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 26 chunks +12 lines, -720 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 6 chunks +0 lines, -18 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 14 chunks +0 lines, -63 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +0 lines, -65 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 2 chunks +0 lines, -246 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 2 chunks +0 lines, -62 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.h View 5 chunks +0 lines, -8 lines 0 comments Download
M cc/trees/thread_proxy.cc View 4 chunks +0 lines, -47 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/TestPlugin.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/layer.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_external_texture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/renderer/compositor_bindings/web_external_texture_layer_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
This is on top of https://codereview.chromium.org/228083002/ danakj: please review the CL enne: OWNERS for webkit/renderer/compositor_bindings ...
6 years, 8 months ago (2014-04-08 05:14:47 UTC) #1
enne (OOO)
webkit/renderer/compositor_bindings lgtm <3 this patch. AcquireLayerTextures was such an abomination.
6 years, 8 months ago (2014-04-08 14:56:55 UTC) #2
brianderson
Thanks piman! Scheduler and Proxy changes lgtm.
6 years, 8 months ago (2014-04-08 15:43:46 UTC) #3
danakj
LGTM and Thank you! https://codereview.chromium.org/227413011/diff/1/cc/scheduler/scheduler_state_machine.h File cc/scheduler/scheduler_state_machine.h (right): https://codereview.chromium.org/227413011/diff/1/cc/scheduler/scheduler_state_machine.h#newcode204 cc/scheduler/scheduler_state_machine.h:204: // Request exclusive access to ...
6 years, 8 months ago (2014-04-08 18:20:32 UTC) #4
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-09 22:17:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/227413011/80001
6 years, 8 months ago (2014-04-09 22:17:41 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 00:41:13 UTC) #7
Message was sent while issue was closed. 
Change committed as 262878

Powered by Google App Engine
This is Rietveld 408576698