Issue 227413010: Revert 262242 "Adding basic G-services handling"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 227413010: Revert 262242 "Adding basic G-services handling" (Closed)

Created:
6 years, 8 months ago by scottmg

Modified:
6 years, 8 months ago

Reviewers:
fgorski

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 262242 "Adding basic G-services handling" Looks like it's failing on various Mac bots: http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20(dbg)(4)/builds/22407 in range http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=%2Ftrunk%2Fsrc&range=262232%3A262247&mode=html > Adding basic G-services handling > > * extracting CheckinRequest::RequestInfo to better manage checkin parameters > * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) > * extracting G-services settings from checkin response > * storing and loading of the G-services settings in GCM Store > > BUG=359254 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 > > Review URL: https://codereview.chromium.org/215363007 TBR=fgorski@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262266

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+78 lines, -297 lines)			Patch
M	trunk/src/google_apis/gcm/engine/checkin_request.h	View	3 chunks	+14 lines, -29 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/checkin_request.cc	View	4 chunks	+15 lines, -27 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/checkin_request_unittest.cc	View	7 chunks	+14 lines, -23 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl.cc	View	9 chunks	+1 line, -107 lines	0 comments	Download
M	trunk/src/google_apis/gcm/engine/gcm_store_impl_unittest.cc	View	2 chunks	+1 line, -49 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client_impl.h	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	trunk/src/google_apis/gcm/gcm_client_impl.cc	View	2 chunks	+14 lines, -19 lines	0 comments	Download
M	trunk/src/google_apis/gcm/tools/mcs_probe.cc	View	2 chunks	+11 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

scottmg

6 years, 8 months ago (2014-04-08 00:27:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r262266 (tree was closed).