Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 215363007: [GCM] Adding basic G-services handling (Closed)

Created:
6 years, 9 months ago by fgorski
Modified:
6 years, 8 months ago
Reviewers:
Nicolas Zea, jianli
CC:
chromium-reviews
Visibility:
Public.

Description

Adding basic G-services handling * extracting CheckinRequest::RequestInfo to better manage checkin parameters * adding G-services settings digest to RequestInfo of the checkin (will be sent with checkin request) * extracting G-services settings from checkin response * storing and loading of the G-services settings in GCM Store BUG=359254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261912 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262242

Patch Set 1 #

Total comments: 35

Patch Set 2 : Addressing the feedback #

Total comments: 10

Patch Set 3 : Adding unit tests and addressing CR feedback #

Total comments: 6

Patch Set 4 : Converting service write to the store to a full replace, adding digest to checkin request, addressi… #

Total comments: 18

Patch Set 5 : Addressing Jian Li's CR comments. #

Total comments: 16

Patch Set 6 : Addressing feedback from Nicolas #

Total comments: 1

Patch Set 7 : Addressing final nit #

Patch Set 8 : Rebasing #

Total comments: 1

Patch Set 9 : Addressing feedback to the updated version #

Patch Set 10 : Removing the G-services handling form GCMClientImpl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -79 lines) Patch
M google_apis/gcm/engine/checkin_request.h View 1 2 3 3 chunks +30 lines, -15 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.cc View 1 2 3 4 chunks +27 lines, -15 lines 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 1 2 3 7 chunks +23 lines, -14 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.h View 1 2 3 4 5 6 7 8 2 chunks +10 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 1 2 3 4 5 6 7 8 9 9 chunks +107 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +49 lines, -1 line 0 comments Download
M google_apis/gcm/gcm_client_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +7 lines, -8 lines 0 comments Download
M google_apis/gcm/gcm_client_impl.cc View 1 2 3 4 5 6 7 8 9 2 chunks +19 lines, -14 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 1 2 3 4 5 6 7 8 9 2 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 34 (0 generated)
fgorski
Guys, this is just a start. It only takes care of periodic checkin and settings ...
6 years, 9 months ago (2014-03-28 02:09:45 UTC) #1
fgorski
self review. https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc File google_apis/gcm/engine/checkin_request.cc (right): https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc#newcode144 google_apis/gcm/engine/checkin_request.cc:144: callback_.Run(response_proto); could we set android_id and security_token ...
6 years, 9 months ago (2014-03-28 14:30:50 UTC) #2
Nicolas Zea
https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc File google_apis/gcm/engine/checkin_request.cc (right): https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc#newcode144 google_apis/gcm/engine/checkin_request.cc:144: callback_.Run(response_proto); On 2014/03/28 14:30:51, Filip Gorski wrote: > could ...
6 years, 9 months ago (2014-03-28 18:31:38 UTC) #3
Nicolas Zea
https://codereview.chromium.org/215363007/diff/20001/google_apis/gcm/engine/gcm_store.h File google_apis/gcm/engine/gcm_store.h (right): https://codereview.chromium.org/215363007/diff/20001/google_apis/gcm/engine/gcm_store.h#newcode51 google_apis/gcm/engine/gcm_store.h:51: std::map<std::string, std::string> g_services_settings; nit: the g_* prefix is typically ...
6 years, 9 months ago (2014-03-28 22:56:52 UTC) #4
fgorski
PTAL. Addressed all of the comments and added unit tests. https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc File google_apis/gcm/engine/checkin_request.cc (right): https://codereview.chromium.org/215363007/diff/1/google_apis/gcm/engine/checkin_request.cc#newcode144 ...
6 years, 9 months ago (2014-03-29 01:09:32 UTC) #5
jianli
https://codereview.chromium.org/215363007/diff/20002/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/215363007/diff/20002/google_apis/gcm/engine/gcm_store_impl.cc#newcode476 google_apis/gcm/engine/gcm_store_impl.cc:476: void GCMStoreImpl::Backend::UpdateGServicesSettings( It seems that the whole update logic ...
6 years, 8 months ago (2014-03-31 17:45:35 UTC) #6
fgorski
PTAL https://codereview.chromium.org/215363007/diff/20002/google_apis/gcm/engine/gcm_store_impl.cc File google_apis/gcm/engine/gcm_store_impl.cc (right): https://codereview.chromium.org/215363007/diff/20002/google_apis/gcm/engine/gcm_store_impl.cc#newcode476 google_apis/gcm/engine/gcm_store_impl.cc:476: void GCMStoreImpl::Backend::UpdateGServicesSettings( On 2014/03/31 17:45:35, jianli wrote: > ...
6 years, 8 months ago (2014-03-31 21:50:08 UTC) #7
jianli
https://codereview.chromium.org/215363007/diff/50001/google_apis/gcm/engine/gcm_store.h File google_apis/gcm/engine/gcm_store.h (right): https://codereview.chromium.org/215363007/diff/50001/google_apis/gcm/engine/gcm_store.h#newcode109 google_apis/gcm/engine/gcm_store.h:109: // |settings_to_remove| and |settings_to_add| don't need to be mutually ...
6 years, 8 months ago (2014-04-01 20:17:17 UTC) #8
fgorski
PTAL https://codereview.chromium.org/215363007/diff/50001/google_apis/gcm/engine/gcm_store.h File google_apis/gcm/engine/gcm_store.h (right): https://codereview.chromium.org/215363007/diff/50001/google_apis/gcm/engine/gcm_store.h#newcode109 google_apis/gcm/engine/gcm_store.h:109: // |settings_to_remove| and |settings_to_add| don't need to be ...
6 years, 8 months ago (2014-04-01 20:47:53 UTC) #9
Nicolas Zea
Mostly LG https://codereview.chromium.org/215363007/diff/70001/google_apis/gcm/engine/gcm_store_impl_unittest.cc File google_apis/gcm/engine/gcm_store_impl_unittest.cc (right): https://codereview.chromium.org/215363007/diff/70001/google_apis/gcm/engine/gcm_store_impl_unittest.cc#newcode1 google_apis/gcm/engine/gcm_store_impl_unittest.cc:1: // Copyright 2014 The Chromium Authors. All ...
6 years, 8 months ago (2014-04-01 21:42:14 UTC) #10
jianli
lgtm
6 years, 8 months ago (2014-04-01 21:56:37 UTC) #11
fgorski
PTAL. I addressed all of the feedback. https://codereview.chromium.org/215363007/diff/70001/google_apis/gcm/engine/gcm_store_impl_unittest.cc File google_apis/gcm/engine/gcm_store_impl_unittest.cc (right): https://codereview.chromium.org/215363007/diff/70001/google_apis/gcm/engine/gcm_store_impl_unittest.cc#newcode1 google_apis/gcm/engine/gcm_store_impl_unittest.cc:1: // Copyright ...
6 years, 8 months ago (2014-04-02 18:22:59 UTC) #12
Nicolas Zea
lgtm https://codereview.chromium.org/215363007/diff/90001/google_apis/gcm/gcm_client_impl_unittest.cc File google_apis/gcm/gcm_client_impl_unittest.cc (right): https://codereview.chromium.org/215363007/diff/90001/google_apis/gcm/gcm_client_impl_unittest.cc#newcode244 google_apis/gcm/gcm_client_impl_unittest.cc:244: protected: nit: just leave these public
6 years, 8 months ago (2014-04-02 18:36:52 UTC) #13
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 8 months ago (2014-04-02 20:26:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/215363007/110001
6 years, 8 months ago (2014-04-02 20:28:06 UTC) #15
fgorski
The CQ bit was unchecked by fgorski@chromium.org
6 years, 8 months ago (2014-04-02 20:49:01 UTC) #16
Nicolas Zea
lgtm https://codereview.chromium.org/215363007/diff/130001/google_apis/gcm/engine/gcm_store.h File google_apis/gcm/engine/gcm_store.h (right): https://codereview.chromium.org/215363007/diff/130001/google_apis/gcm/engine/gcm_store.h#newcode113 google_apis/gcm/engine/gcm_store.h:113: // Persists |settings|, |settings_digest| and |last_checkin_time|. It nit: ...
6 years, 8 months ago (2014-04-04 20:09:56 UTC) #17
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 8 months ago (2014-04-04 20:13:59 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/215363007/150001
6 years, 8 months ago (2014-04-04 20:14:28 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 20:51:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-04 20:51:32 UTC) #21
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 8 months ago (2014-04-04 21:27:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/215363007/150001
6 years, 8 months ago (2014-04-04 21:39:12 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 21:47:51 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-04 21:47:52 UTC) #25
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 8 months ago (2014-04-04 22:23:00 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/215363007/150001
6 years, 8 months ago (2014-04-04 22:23:24 UTC) #27
commit-bot: I haz the power
Change committed as 261912
6 years, 8 months ago (2014-04-04 23:03:56 UTC) #28
tommycli
A revert of this CL has been created in https://codereview.chromium.org/226893002/ by tommycli@chromium.org. The reason for ...
6 years, 8 months ago (2014-04-04 23:47:24 UTC) #29
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 8 months ago (2014-04-07 21:06:26 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/215363007/170001
6 years, 8 months ago (2014-04-07 21:06:35 UTC) #31
commit-bot: I haz the power
Change committed as 262242
6 years, 8 months ago (2014-04-07 23:13:51 UTC) #32
jam
please fix https://code.google.com/p/chromium/issues/detail?id=341513 before landing this change, it's unacceptable that there tests which break the ...
6 years, 8 months ago (2014-04-08 00:31:19 UTC) #33
Nico
6 years, 8 months ago (2014-04-08 02:40:49 UTC) #34

Powered by Google App Engine
This is Rietveld 408576698