Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1747)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.cc

Issue 227413008: Add the feature to retain the user gesture in the extension callback (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.cc
===================================================================
--- chrome/browser/extensions/api/permissions/permissions_api.cc (revision 262146)
+++ chrome/browser/extensions/api/permissions/permissions_api.cc (working copy)
@@ -129,6 +129,7 @@
perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
results_ = Request::Results::Create(true);
+ response_user_gesture_ = true;
SendResponse(true);
Release(); // Balanced in RunImpl().
@@ -188,6 +189,7 @@
PermissionsUpdater perms_updater(GetProfile());
perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
results_ = Request::Results::Create(true);
+ //response_user_gesture_ = true;
wjywbs 2014/04/07 21:46:37 This can cause security issues same as chrome.test
not at google - send to devlin 2014/04/07 22:09:09 how?
SendResponse(true);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698