Add the feature to retain the user gesture in the extension callback

chrome/browser/extensions/api/permissions/permissions_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/permissions/permissions_api.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/permissions/permissions_api_helpers.h"
 #include "chrome/browser/extensions/permissions_updater.h"
@@ skipping 111 matching lines @@
   ignore_user_gesture_for_tests = ignore;
 }
 
 PermissionsRequestFunction::PermissionsRequestFunction() {}
 
 void PermissionsRequestFunction::InstallUIProceed() {
   PermissionsUpdater perms_updater(GetProfile());
   perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
 
   results_ = Request::Results::Create(true);
+  response_user_gesture_ = true;
   SendResponse(true);
 
   Release();  // Balanced in RunImpl().
 }
 
 void PermissionsRequestFunction::InstallUIAbort(bool user_initiated) {
   SendResponse(true);
 
   Release();  // Balanced in RunImpl().
 }
@@ skipping 39 matching lines @@
   }
 
   // We don't need to prompt the user if the requested permissions are a subset
   // of the granted permissions set.
   scoped_refptr<const PermissionSet> granted = ExtensionPrefs::Get(
       GetProfile())->GetGrantedPermissions(GetExtension()->id());
   if (granted.get() && granted->Contains(*requested_permissions_.get())) {
     PermissionsUpdater perms_updater(GetProfile());
     perms_updater.AddPermissions(GetExtension(), requested_permissions_.get());
     results_ = Request::Results::Create(true);
+    //response_user_gesture_ = true;

[wjywbs, 2014/04/07 21:46:37]

This can cause security issues same as chrome.test.runWithUserGesture.

[not at google - send to devlin, 2014/04/07 22:09:09]

how?

     SendResponse(true);
     return true;
   }
 
   // Filter out the granted permissions so we only prompt for new ones.
   requested_permissions_ = PermissionSet::CreateDifference(
       requested_permissions_.get(), granted.get());
 
   AddRef();  // Balanced in InstallUIProceed() / InstallUIAbort().
 
@@ skipping 13 matching lines @@
     CHECK_EQ(DO_NOT_SKIP, auto_confirm_for_tests);
     install_ui_.reset(new ExtensionInstallPrompt(GetAssociatedWebContents()));
     install_ui_->ConfirmPermissions(
         this, GetExtension(), requested_permissions_.get());
   }
 
   return true;
 }
 
 }  // namespace extensions