Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2273943002: VM: More refactoring of recognized methods inlining. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: More refactoring of recognized methods inlining. Move inlining OneByteString._setAt, List constructor, Object constructor and a few math function to the flow-graph inliner. Enable inlining of trigonometric math functions in AOT that were previously not inlined. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7d6f78b88f610608cf043bf1585613a15745aca6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -501 lines) Patch
M runtime/vm/aot_optimizer.cc View 7 chunks +21 lines, -160 lines 0 comments Download
M runtime/vm/flow_graph.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph.cc View 6 chunks +20 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_inliner.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 9 chunks +147 lines, -23 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +3 lines, -18 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 2 chunks +1 line, -29 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 2 chunks +1 line, -12 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +1 line, -23 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 2 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +1 line, -26 lines 0 comments Download
M runtime/vm/jit_optimizer.cc View 7 chunks +20 lines, -172 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 4 months ago (2016-08-23 23:57:02 UTC) #2
rmacnak
LGTM
4 years, 4 months ago (2016-08-24 17:21:07 UTC) #3
Florian Schneider
4 years, 4 months ago (2016-08-24 17:35:12 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7d6f78b88f610608cf043bf1585613a15745aca6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698