Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 2273943002: VM: More refactoring of recognized methods inlining. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_dbc.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
diff --git a/runtime/vm/intermediate_language_ia32.cc b/runtime/vm/intermediate_language_ia32.cc
index 3ccb078f787cb6b9f0abd67d2ebcabf6395e1c20..1595297274d20bf943469181f58d63b28494b2ad 100644
--- a/runtime/vm/intermediate_language_ia32.cc
+++ b/runtime/vm/intermediate_language_ia32.cc
@@ -4904,18 +4904,6 @@ void BinaryInt32x4OpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
LocationSummary* MathUnaryInstr::MakeLocationSummary(Zone* zone,
bool opt) const {
- if ((kind() == MathUnaryInstr::kSin) || (kind() == MathUnaryInstr::kCos)) {
- const intptr_t kNumInputs = 1;
- const intptr_t kNumTemps = 1;
- LocationSummary* summary = new(zone) LocationSummary(
- zone, kNumInputs, kNumTemps, LocationSummary::kCall);
- summary->set_in(0, Location::FpuRegisterLocation(XMM1));
- // EDI is chosen because it is callee saved so we do not need to back it
- // up before calling into the runtime.
- summary->set_temp(0, Location::RegisterLocation(EDI));
- summary->set_out(0, Location::FpuRegisterLocation(XMM1));
- return summary;
- }
ASSERT((kind() == MathUnaryInstr::kSqrt) ||
(kind() == MathUnaryInstr::kDoubleSquare));
const intptr_t kNumInputs = 1;
@@ -4940,17 +4928,7 @@ void MathUnaryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ mulsd(value_reg, value_reg);
ASSERT(value_reg == locs()->out(0).fpu_reg());
} else {
- ASSERT((kind() == MathUnaryInstr::kSin) ||
- (kind() == MathUnaryInstr::kCos));
- // Save ESP.
- __ movl(locs()->temp(0).reg(), ESP);
- __ ReserveAlignedFrameSpace(kDoubleSize * InputCount());
- __ movsd(Address(ESP, 0), locs()->in(0).fpu_reg());
- __ CallRuntime(TargetFunction(), InputCount());
- __ fstpl(Address(ESP, 0));
- __ movsd(locs()->out(0).fpu_reg(), Address(ESP, 0));
- // Restore ESP.
- __ movl(ESP, locs()->temp(0).reg());
+ UNREACHABLE();
}
}
« no previous file with comments | « runtime/vm/intermediate_language_dbc.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698