Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2273923002: Revert of Fix Closure Compiler's compile.py error checking to match compile2.py. (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Closure Compiler's compile.py error checking to match compile2.py. (patchset #2 id:20001 of https://codereview.chromium.org/2273813002/ ) Reason for revert: https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/67299 Original issue's description: > Fix Closure Compiler's compile.py error checking to match compile2.py. > > Without this change compile.py will fail when there are no errors > > Committed: https://crrev.com/8275e261f1d65af32665ea90585ded450b48dfb8 > Cr-Commit-Position: refs/heads/master@{#413859} TBR=tbreisacher@chromium.org,doloffd@amazon.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/50c0cef7a435f844c2a94a45dc500983ab20bc83 Cr-Commit-Position: refs/heads/master@{#413869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/closure_compiler/compile.py View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/closure_compiler/compile2.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dan Beam
Created Revert of Fix Closure Compiler's compile.py error checking to match compile2.py.
4 years, 4 months ago (2016-08-23 22:38:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273923002/1
4 years, 4 months ago (2016-08-23 22:39:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 22:40:00 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 22:42:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c0cef7a435f844c2a94a45dc500983ab20bc83
Cr-Commit-Position: refs/heads/master@{#413869}

Powered by Google App Engine
This is Rietveld 408576698