Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2273923002: Revert of Fix Closure Compiler's compile.py error checking to match compile2.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/compile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/closure_compiler/compile2.py
diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py
index f952d2cbac19a78cd0e5cd96c4f0d59626c9e3c3..59de787db165d03ba40e782322d844e06d65eafe 100755
--- a/third_party/closure_compiler/compile2.py
+++ b/third_party/closure_compiler/compile2.py
@@ -267,20 +267,20 @@
processed_runner_args = ["--%s" % arg for arg in runner_args or []]
processed_runner_args += ["--compiler-args-file=%s" % args_file]
- return_code, stderr = self._run_jar(self._runner_jar, processed_runner_args)
+ _, stderr = self._run_jar(self._runner_jar, processed_runner_args)
errors = stderr.strip().split("\n\n")
maybe_summary = errors.pop()
- if return_code == 0:
+ summary = re.search("(?P<error_count>\d+).*error.*warning", maybe_summary)
+ if summary:
self._log_debug("Summary: %s" % maybe_summary)
else:
- # Running the jar failed. Bail.
+ # Not a summary. Running the jar failed. Bail.
self._log_error(stderr)
self._nuke_temp_files()
sys.exit(1)
- summary = re.search("(?P<error_count>\d+).*error.*warning", maybe_summary)
if summary.group('error_count') != "0" and out_file:
if os.path.exists(out_file):
os.remove(out_file)
« no previous file with comments | « third_party/closure_compiler/compile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698