Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2273913002: Make dart recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
wheese, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -109 lines) Patch
M scripts/slave/recipes/dart/dart.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart2js.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart2js_nobuild.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_cross_compiler.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_cross_tester.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dart_vm.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_build.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_linux_64_MirrorFalse.json View 4 chunks +54 lines, -17 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_linux_64_MirrorTrue.json View 4 chunks +54 lines, -17 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_mac_64_MirrorFalse.json View 4 chunks +54 lines, -17 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_mac_64_MirrorTrue.json View 4 chunks +54 lines, -17 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_win_64_MirrorFalse.json View 4 chunks +54 lines, -17 lines 0 comments Download
M scripts/slave/recipes/dart/dartium_build.expected/basic_win_64_MirrorTrue.json View 4 chunks +54 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
4 years, 4 months ago (2016-08-23 22:36:55 UTC) #1
martiniss
lgtm
4 years, 4 months ago (2016-08-23 22:49:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273913002/1
4 years, 3 months ago (2016-08-24 20:13:48 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 20:18:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/1841f028ff591483facb...

Powered by Google App Engine
This is Rietveld 408576698