scripts/slave/recipes/dart/dartium_build.py - Issue 2273913002: Make dart recipes explicitly set GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/dart/dartium_build.py

Issue 2273913002: Make dart recipes explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/dart/dartium_build.py

diff --git a/scripts/slave/recipes/dart/dartium_build.py b/scripts/slave/recipes/dart/dartium_build.py

index e30959566972b05652be6c488deb46bf84d93de2..090995a6763f3bf4be72c9230d58c978f0f37c5d 100644

--- a/scripts/slave/recipes/dart/dartium_build.py

+++ b/scripts/slave/recipes/dart/dartium_build.py

@@ -18,7 +18,7 @@ def RunSteps(api):

)

api.chromium.set_config('chromium', **config_vals)

- api.gclient.set_config('chromium', **config_vals)

+ api.gclient.set_config('chromium', GIT_MODE=True, **config_vals)

api.chromium.c.gyp_env.GYP_GENERATORS.add('ninja')

api.chromium.c.gyp_env.GYP_DEFINES['linux_strip_binary'] = 1