Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 22739002: Make grit resource maps work also for strings (Closed)

Created:
7 years, 4 months ago by sigbjorn
Modified:
7 years, 4 months ago
Reviewers:
tony, Jói
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Make grit resource maps work also for strings BUG=

Patch Set 1 #

Patch Set 2 : Add unittest for string resource maps #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M grit/format/resource_map.py View 1 chunk +9 lines, -3 lines 0 comments Download
M grit/format/resource_map_unittest.py View 1 1 chunk +57 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
sigbjorn
Not sure who to put as a reviewer, does anyone know?
7 years, 4 months ago (2013-08-09 11:07:19 UTC) #1
tony
Can you explain why you need this? That is, how are you using resource maps ...
7 years, 4 months ago (2013-08-09 17:14:32 UTC) #2
sigbjorn
On 2013/08/09 17:14:32, tony wrote: > Can you explain why you need this? That is, ...
7 years, 4 months ago (2013-08-10 13:35:09 UTC) #3
tony
On 2013/08/10 13:35:09, sigbjorn wrote: > On 2013/08/09 17:14:32, tony wrote: > > Can you ...
7 years, 4 months ago (2013-08-12 17:05:04 UTC) #4
sigbjorn
> With this change, a Python call will look like: > > GetLocalizedString('IDS_PRODUCT_NAME') > > ...
7 years, 4 months ago (2013-08-13 07:13:09 UTC) #5
sigbjorn
Test added.
7 years, 4 months ago (2013-08-13 08:27:09 UTC) #6
tony
LGTM, I'll make the fixes and land the patch. https://codereview.chromium.org/22739002/diff/7001/grit/format/resource_map_unittest.py File grit/format/resource_map_unittest.py (right): https://codereview.chromium.org/22739002/diff/7001/grit/format/resource_map_unittest.py#newcode103 grit/format/resource_map_unittest.py:103: ...
7 years, 4 months ago (2013-08-13 17:21:22 UTC) #7
tony
7 years, 4 months ago (2013-08-13 17:30:26 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698