scripts/slave/recipe_modules/v8/api.py - Issue 2273833002: Make v8 recipes explicitly set GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2273833002: Make v8 recipes explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/api.py

diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py

index d3d2495e009aac1366a6df276863fa7071d95064..109f74310e793723b2ee9c6d6246e42ef5e47c00 100644

--- a/scripts/slave/recipe_modules/v8/api.py

+++ b/scripts/slave/recipe_modules/v8/api.py

@@ -89,7 +89,7 @@ class V8Api(recipe_api.RecipeApi):

kwargs = self.bot_config.get('v8_config_kwargs', {})

self.set_config('v8', optional=True, **kwargs)

self.m.chromium.set_config('v8', **kwargs)

- self.m.gclient.set_config('v8', **kwargs)

+ self.m.gclient.set_config('v8', GIT_MODE=True, **kwargs)

for c in self.bot_config.get('gclient_apply_config', []):

self.m.gclient.apply_config(c)

« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json » ('j') | no next file with comments »