Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2273833002: Make v8 recipes explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import argparse 5 import argparse
6 import contextlib 6 import contextlib
7 import datetime 7 import datetime
8 import difflib 8 import difflib
9 import random 9 import random
10 import re 10 import re
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 buildername = self.m.properties.get('buildername') 82 buildername = self.m.properties.get('buildername')
83 master_dict = builders.get(mastername, {}) 83 master_dict = builders.get(mastername, {})
84 self.bot_config = master_dict.get('builders', {}).get(buildername) 84 self.bot_config = master_dict.get('builders', {}).get(buildername)
85 assert self.bot_config, ( 85 assert self.bot_config, (
86 'Unrecognized builder name %r for master %r.' % ( 86 'Unrecognized builder name %r for master %r.' % (
87 buildername, mastername)) 87 buildername, mastername))
88 88
89 kwargs = self.bot_config.get('v8_config_kwargs', {}) 89 kwargs = self.bot_config.get('v8_config_kwargs', {})
90 self.set_config('v8', optional=True, **kwargs) 90 self.set_config('v8', optional=True, **kwargs)
91 self.m.chromium.set_config('v8', **kwargs) 91 self.m.chromium.set_config('v8', **kwargs)
92 self.m.gclient.set_config('v8', **kwargs) 92 self.m.gclient.set_config('v8', GIT_MODE=True, **kwargs)
93 93
94 for c in self.bot_config.get('gclient_apply_config', []): 94 for c in self.bot_config.get('gclient_apply_config', []):
95 self.m.gclient.apply_config(c) 95 self.m.gclient.apply_config(c)
96 for c in self.bot_config.get('chromium_apply_config', []): 96 for c in self.bot_config.get('chromium_apply_config', []):
97 self.m.chromium.apply_config(c) 97 self.m.chromium.apply_config(c)
98 if self.m.tryserver.is_tryserver: 98 if self.m.tryserver.is_tryserver:
99 self.init_tryserver() 99 self.init_tryserver()
100 for c in self.bot_config.get('v8_apply_config', []): 100 for c in self.bot_config.get('v8_apply_config', []):
101 self.apply_config(c) 101 self.apply_config(c)
102 102
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 def report_culprits(self, culprit_range): 1233 def report_culprits(self, culprit_range):
1234 assert culprit_range 1234 assert culprit_range
1235 if len(culprit_range) > 1: 1235 if len(culprit_range) > 1:
1236 text = 'Suspecting multiple commits' 1236 text = 'Suspecting multiple commits'
1237 else: 1237 else:
1238 text = 'Suspecting %s' % culprit_range[0][:8] 1238 text = 'Suspecting %s' % culprit_range[0][:8]
1239 1239
1240 step_result = self.m.step(text, cmd=None) 1240 step_result = self.m.step(text, cmd=None)
1241 for culprit in culprit_range: 1241 for culprit in culprit_range:
1242 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1242 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698