Framework and tests for WorkerNavigatorBudget

Framework and tests for WorkerNavigatorBudget

This CL provides a Worker entrypoint for the BudgetAPI. The WorkerNavigator
partial interface provides a BudgetService object, which is the same for
both Navigator and WorkerNavigator.

BUG=617971
Committed: https://crrev.com/48002352c0a882279f25decc05b61c73c15795a5
Cr-Commit-Position: refs/heads/master@{#414579}

[harkness, 2016-08-23 16:10:50]

harkness@chromium.org changed reviewers:
+ peter@chromium.org

[harkness, 2016-08-23 16:10:51]

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html
(right):

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/budget/get-budget-in-service-worker.html:8:
<script src="../notifications/resources/test-helpers.js"></script>
I could also copy the helpers from notifications to budget, but it seemed better
to avoid the code duplication.

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl (right):

https://codereview.chromium.org/2273743002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.idl:5: //
TODO(harkness): Update to WorkerNavigator partial interface documentation.
I'm not sure why git is picking this up as a modified file rather than a new
file. I'll look into it.

[Peter Beverloo, 2016-08-24 15:28:23]

lgtm

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:10:
var options = event.data.options || {}
;

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:17:
cost: cost });
The alignment of this (and lines 23+, 31+, 39+ and 52+) is kind of odd. Normally
we align objects like:

port.postMessage({
    command: event.data.command,
    foo: 'bar'
});

or

port.postMessage({ command: event.data.command,
                   foo: 'bar' });

[Peter Beverloo, 2016-08-24 15:31:05]

Sorry, two more IWYU comments:

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h (right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h:8: #include
"platform/Supplementable.h"
#include "platform/heap/GarbageCollected.h"
#include "wtf/Noncopyable.h"

[harkness, 2016-08-24 16:22:50]

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:10:
var options = event.data.options || {}
On 2016/08/24 15:28:23, Peter Beverloo wrote:
> ;

Done.

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js:17:
cost: cost });
On 2016/08/24 15:28:23, Peter Beverloo wrote:
> The alignment of this (and lines 23+, 31+, 39+ and 52+) is kind of odd.
Normally
> we align objects like:
> 
> port.postMessage({
>     command: event.data.command,
>     foo: 'bar'
> });
> 
> or
> 
> port.postMessage({ command: event.data.command,
>                    foo: 'bar' });

Done.

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h (right):

https://codereview.chromium.org/2273743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h:8: #include
"platform/Supplementable.h"
On 2016/08/24 15:31:04, Peter Beverloo wrote:
> #include "platform/heap/GarbageCollected.h"
> #include "wtf/Noncopyable.h"

Done.

[harkness, 2016-08-24 16:23:05]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 16:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 17:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 17:36:22]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[harkness, 2016-08-24 22:03:47]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 22:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:36:49]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[harkness, 2016-08-25 07:53:02]

The CQ bit was checked by harkness@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 07:53:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 12:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 12:03:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Beverloo, 2016-08-25 12:20:53]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-08-25 12:20:54]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2273743002/#ps60001
(title: "Add budget interface to global serviceworker interfaces")

[commit-bot: I haz the power, 2016-08-25 12:21:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 15:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 15:48:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[harkness, 2016-08-25 16:13:47]

The CQ bit was checked by harkness@chromium.org

[harkness, 2016-08-25 16:13:48]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2273743002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-25 16:14:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:49:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 18:49:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[harkness, 2016-08-25 21:12:08]

The CQ bit was checked by harkness@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:12:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:19:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-25 23:23:16]

Description was changed from

==========
Framework and tests for WorkerNavigatorBudget

This CL provides a Worker entrypoint for the BudgetAPI. The WorkerNavigator
partial interface provides a BudgetService object, which is the same for
both Navigator and WorkerNavigator.

BUG=617971
==========

to

==========
Framework and tests for WorkerNavigatorBudget

This CL provides a Worker entrypoint for the BudgetAPI. The WorkerNavigator
partial interface provides a BudgetService object, which is the same for
both Navigator and WorkerNavigator.

BUG=617971

Committed: https://crrev.com/48002352c0a882279f25decc05b61c73c15795a5
Cr-Commit-Position: refs/heads/master@{#414579}
==========

[commit-bot: I haz the power, 2016-08-25 23:23:16]

Patchset 5 (id:??) landed as
https://crrev.com/48002352c0a882279f25decc05b61c73c15795a5
Cr-Commit-Position: refs/heads/master@{#414579}