Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
index 51ba61a70db6f376a7655c13b83e965a9dd4d57b..d21076f6e55d45c2692ed624ef60fd19084e0611 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
@@ -5,7 +5,6 @@
#ifndef WebGLVertexArrayObjectBase_h
#define WebGLVertexArrayObjectBase_h
-#include "bindings/core/v8/ScopedPersistent.h"
#include "modules/webgl/WebGLBuffer.h"
#include "modules/webgl/WebGLContextObject.h"
#include "platform/heap/Handle.h"
@@ -38,7 +37,7 @@ public:
bool isAllEnabledAttribBufferBound() const { return m_isAllEnabledAttribBufferBound; }
void unbindBuffer(WebGLBuffer*);
- ScopedPersistent<v8::Array>* getPersistentCache();
+ virtual void visitChildDOMWrappers(v8::Isolate*, const v8::Persistent<v8::Object>&);
DECLARE_VIRTUAL_TRACE();
@@ -61,10 +60,6 @@ private:
HeapVector<Member<WebGLBuffer>> m_arrayBufferList;
Vector<bool> m_attribEnabled;
bool m_isAllEnabledAttribBufferBound;
-
- // For preserving the wrappers of WebGLBuffer objects latched in
- // via vertexAttribPointer calls.
- ScopedPersistent<v8::Array> m_arrayBufferWrappers;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698