Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

Issue 2273683003: Use visitDOMWrapper to preserve WebGL JS object wrappers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: style Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
index f5370cb50413efde620cf9409ffcbb5097405bac..8cd17dda8f3a44eb06d8eec0c07362d8e58469b9 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
@@ -140,9 +140,12 @@ void WebGLVertexArrayObjectBase::unbindBuffer(WebGLBuffer* buffer)
updateAttribBufferBoundStatus();
}
-ScopedPersistent<v8::Array>* WebGLVertexArrayObjectBase::getPersistentCache()
+void WebGLVertexArrayObjectBase::visitChildDOMWrappers(v8::Isolate* isolate, const v8::Persistent<v8::Object>& wrapper)
{
- return &m_arrayBufferWrappers;
+ DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, m_boundElementArrayBuffer, isolate);
+ for (size_t i = 0; i < m_arrayBufferList.size(); ++i) {
+ DOMWrapperWorld::setWrapperReferencesInAllWorlds(wrapper, m_arrayBufferList[i], isolate);
+ }
}
DEFINE_TRACE(WebGLVertexArrayObjectBase)
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698