Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2273673002: Reland of "[heap] Tracer: Handle incremental marking scopes" (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Tracer: Handle incremental marking scopes Before this patch all tracing scopes in incremental marking would be reset during a gc tracer start/stop cycle. This patch handles scopes the same way it does other incremental marking metrics. Also: - Align finalization metric with regular marking metric. - Smaller cleanups BUG=chromium:639818 Committed: https://crrev.com/7695642e2c7d893d300920ac0084905288f72859 Cr-Commit-Position: refs/heads/master@{#38834}

Patch Set 1 #

Patch Set 2 : Add ResetForTesting to new unittests #

Patch Set 3 : GCTracer::ResetForTesting: cover new members #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -205 lines) Patch
M src/heap/gc-tracer.h View 8 chunks +108 lines, -53 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 2 12 chunks +103 lines, -55 lines 0 comments Download
M src/heap/incremental-marking.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +0 lines, -97 lines 0 comments Download
M test/unittests/heap/gc-tracer-unittest.cc View 1 2 chunks +138 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
Michael Lippautz
4 years, 4 months ago (2016-08-23 14:51:08 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 14:52:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273673002/40001
4 years, 4 months ago (2016-08-23 15:11:26 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-23 15:13:29 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 15:14:08 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7695642e2c7d893d300920ac0084905288f72859
Cr-Commit-Position: refs/heads/master@{#38834}

Powered by Google App Engine
This is Rietveld 408576698