Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2269093002:
[heap] GCTracer: Record details for incremental marking (Closed)
|
Created:
4 years, 4 months ago by Michael Lippautz Modified:
4 years, 3 months ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@tracer-reland Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] GCTracer: Record details for incremental marking
Record details, such as cumulative duration, number of steps, and longest steps
in IncrementalMarkingDetails which get populated at a single callsite
(AddScopeSample). Remove member fields that thus become obsolete (unfortunately
not all of them).
Additional remove some dead code and refactor printing. Printing in a single
statement allows for using logcat on Android.
This should also address the regression in chromium:640524.
BUG=chromium:639818, chromium:640524
R=jochen@chromium.org
Committed: https://crrev.com/3866975f1b159f3703429ce50ca228bcdbf28306
Cr-Commit-Position: refs/heads/master@{#38912}
Patch Set 1 #Patch Set 2 : More cleanup #Patch Set 3 : Rebase on master #Patch Set 4 : Remove default ctor from Event, more comments #Patch Set 5 : Add longest step for wrapper tracing #Patch Set 6 : Remove one more dead variable #Patch Set 7 : Fix regression in ::Stop and inline ::AddScopeSample #
Messages
Total messages: 34 (28 generated)
Description was changed from ========== Test fixes [heap] GCTracer: Record details for incremental marking Get rid of all the variables that do this manually. BUG= ========== to ========== [heap] GCTracer: Record details for incremental marking Get rid of all the variables that do this manually. BUG= ==========
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Get rid of all the variables that do this manually. BUG= ========== to ========== [heap] GCTracer: Record details for incremental marking - Get rid of all the variables that do this manually. - Clean up GCTracer. BUG= ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== [heap] GCTracer: Record details for incremental marking - Get rid of all the variables that do this manually. - Clean up GCTracer. BUG= ========== to ========== [heap] GCTracer: Record details for incremental marking - Get rid of all the variables that do this manually. - Clean up GCTracer. BUG=chromium:639818 ==========
Description was changed from ========== [heap] GCTracer: Record details for incremental marking - Get rid of all the variables that do this manually. - Clean up GCTracer. BUG=chromium:639818 ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, #steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete. Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ==========
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, #steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete. Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete. Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ==========
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete. Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 R=jochen@chromium.org ==========
mlippautz@chromium.org changed reviewers: + jochen@chromium.org
PTAL This CL adds the missing parts for tracking GC scopes during incremental marking (using IncrementalMarkingDetails) and at the same time allows us to remove quite some members that were used to track some parts manually. This should be enough to properly evaluate object grouping vs incremental wrapper tracing.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #7 (id:140001) has been deleted
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
+Ulan ;)
lgtm!
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. BUG=chromium:639818 R=jochen@chromium.org ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/2269093002/#ps160001 (title: "Fix regression in ::Stop and inline ::AddScopeSample")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #7 (id:160001)
Message was sent while issue was closed.
Description was changed from ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org ========== to ========== [heap] GCTracer: Record details for incremental marking Record details, such as cumulative duration, number of steps, and longest steps in IncrementalMarkingDetails which get populated at a single callsite (AddScopeSample). Remove member fields that thus become obsolete (unfortunately not all of them). Additional remove some dead code and refactor printing. Printing in a single statement allows for using logcat on Android. This should also address the regression in chromium:640524. BUG=chromium:639818,chromium:640524 R=jochen@chromium.org Committed: https://crrev.com/3866975f1b159f3703429ce50ca228bcdbf28306 Cr-Commit-Position: refs/heads/master@{#38912} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/3866975f1b159f3703429ce50ca228bcdbf28306 Cr-Commit-Position: refs/heads/master@{#38912} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
