Implement toString() funtion in DOMMatrixReadOnly.

Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
Committed: https://crrev.com/9b40862bbf0ef208bae308ee4004637a61151430
Cr-Commit-Position: refs/heads/master@{#414228}

[Hwanseung Lee, 2016-08-23 14:03:29]

Description was changed from

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
==========

to

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
==========

[Hwanseung Lee, 2016-08-23 14:03:29]

hs1217.lee@samsung.com changed reviewers:
+ jinho.bang@samsung.com, pdr@chromium.org

[Hwanseung Lee, 2016-08-23 14:04:01]

PTAL. thank you.

[pdr., 2016-08-23 18:00:55]

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html
(right):

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html:45:
assert_equals(matrix2d.toString(), "matrix(1, 2, 3, 2, 1)");
Should this be "matrix(1, 2, 3, 2, 1)" instead of "matrix(1, 2, 3, 3.1, 2, 1)"?

[pdr., 2016-08-23 18:24:30]

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:64: const AtomicString
toString() const;
Can you use String here instead of AtomicString? I think it'll be slightly
faster because we don't really need the AtomicString machinery here.

[Hwanseung Lee, 2016-08-23 21:35:01]

@pdr. i did fix a some problem. could you review again? thank you.

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html
(right):

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html:45:
assert_equals(matrix2d.toString(), "matrix(1, 2, 3, 2, 1)");
On 2016/08/23 18:00:55, pdr. wrote:
> Should this be "matrix(1, 2, 3, 2, 1)" instead of "matrix(1, 2, 3, 3.1, 2,
1)"?

it was missing about d(). it was fixed.

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):

https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:64: const AtomicString
toString() const;
On 2016/08/23 18:24:30, pdr. wrote:
> Can you use String here instead of AtomicString? I think it'll be slightly
> faster because we don't really need the AtomicString machinery here.

it was changed to String instead of AtomicString.

[pdr., 2016-08-24 18:20:29]

On 2016/08/23 at 21:35:01, hs1217.lee wrote:
> @pdr. i did fix a some problem. could you review again? thank you.
> 
>
https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html
(right):
> 
>
https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Layo...
>
third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-readonly.html:45:
assert_equals(matrix2d.toString(), "matrix(1, 2, 3, 2, 1)");
> On 2016/08/23 18:00:55, pdr. wrote:
> > Should this be "matrix(1, 2, 3, 2, 1)" instead of "matrix(1, 2, 3, 3.1, 2,
1)"?
> 
> it was missing about d(). it was fixed.
> 
>
https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h (right):
> 
>
https://codereview.chromium.org/2273663002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h:64: const AtomicString
toString() const;
> On 2016/08/23 18:24:30, pdr. wrote:
> > Can you use String here instead of AtomicString? I think it'll be slightly
> > faster because we don't really need the AtomicString machinery here.
> 
> it was changed to String instead of AtomicString.

LGTM

[Hwanseung Lee, 2016-08-24 21:16:09]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-08-24 21:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:20:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:20:09]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hwanseung Lee, 2016-08-24 23:35:40]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2016-08-24 23:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:40:24]

Description was changed from

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
==========

to

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
==========

[commit-bot: I haz the power, 2016-08-25 00:40:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 00:42:55]

Description was changed from

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780
==========

to

==========
Implement toString() funtion in DOMMatrixReadOnly.

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780

Committed: https://crrev.com/9b40862bbf0ef208bae308ee4004637a61151430
Cr-Commit-Position: refs/heads/master@{#414228}
==========

[commit-bot: I haz the power, 2016-08-25 00:42:56]

Patchset 3 (id:??) landed as
https://crrev.com/9b40862bbf0ef208bae308ee4004637a61151430
Cr-Commit-Position: refs/heads/master@{#414228}