Move reload processing from TranslateManager to TranslateTabHelper.

Move reload processing from TranslateManager to TranslateTabHelper.

This reload processing is specific to the //chrome embedder flow, wherein the
LanguageDetermined IPC (which initiates translation) is not sent from the
renderer on a reload, and thus the browser-side code must explicitly listen for
reloads to initiate translation as appropriate. If the relevant renderer code
ever moves into the component, then this browser-side reload handling could
move into the content driver of the component.

BUG=359998
R=droger@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262378

[blundell, 2014-04-07 08:03:01]

The logic for why I put the cutpoints where I did in this CL is not quite
trivial.
This CL is dependent on https://codereview.chromium.org/227043005/.

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_tab_helper.cc (right):

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:184: // Check whether this is a
reload: When doing a page reload, the
A couple notes here:

- The WCO method NavigationEntryCommitted() corresponds to the
NAV_ENTRY_COMMITTED notification, but is the currently-preferred mechanism.
- The logic here is simplified from what it previously was, as some of the
safety checks (e.g. that the WebContents in question isn't NULL) are no longer
necessary.

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:190: if (!entry) {
I don't really know why there are all these checks sprinkled throughout the
translate code: it seems kind of bizarrely paranoid.

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:211: if
(entry->GetTransitionType() != content::PAGE_TRANSITION_RELOAD &&
I actually think it would be clearest if this check was the first one made, but
wanted to limit the diff from the previous version of this code for ease of
reviewing.

[droger, 2014-04-07 11:14:41]

Nit: The CL description should be about TranslateTabHelper, not
TranslateTabContents.

I agree with the cut points as per offline discussion.
The rationale is that this logic seems embedder specific and thus should belong
to the embedder, even though the core code could implement it fine.

LGTM, with the two nits addressed.

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_tab_helper.cc (right):

https://codereview.chromium.org/227363005/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_tab_helper.cc:223: // infobar, it must
Nit: format.

[blundell, 2014-04-08 09:20:18]

Nits addressed, thanks.

[blundell, 2014-04-08 12:13:39]

Committed patchset #3 manually as r262378 (presubmit successful).