Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 227363005: Move reload processing from TranslateManager to TranslateTabHelper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
index b9514a39db5a6e6ec1f975a9b010ff178cc87219..055465536f7f5b27a9eb371be4a542469fd4fbc9 100644
--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
@@ -263,9 +263,8 @@ class TranslateManagerRenderViewHostTest
ChromeRenderViewHostTestHarness::SetUp();
InfoBarService::CreateForWebContents(web_contents());
TranslateTabHelper::CreateForWebContents(web_contents());
- TranslateManager* manager =
- TranslateTabHelper::GetManagerFromWebContents(web_contents());
- manager->set_translate_max_reload_attemps(0);
+ TranslateTabHelper::FromWebContents(web_contents())
+ ->set_translate_max_reload_attempts(0);
notification_registrar_.Add(
this,
@@ -779,9 +778,8 @@ TEST_F(TranslateManagerRenderViewHostTest, Reload) {
// If we set reload attempts to a high value, we will not see the infobar
// immediately.
- TranslateManager* manager =
- TranslateTabHelper::GetManagerFromWebContents(web_contents());
- manager->set_translate_max_reload_attemps(100);
+ TranslateTabHelper::FromWebContents(web_contents())
+ ->set_translate_max_reload_attempts(100);
ReloadAndWait(true);
EXPECT_TRUE(GetTranslateInfoBar() == NULL);
}
« no previous file with comments | « chrome/browser/translate/translate_manager.cc ('k') | chrome/browser/translate/translate_tab_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698