Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2273523002: [MD History] Prevent horizontal scrolling of history views. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 3 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_CBD_button
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Prevent horizontal scrolling of history views. This CL fixes an issue where the overlay scrollbar would allow Chrome to scroll to the right to show the space covered by the vertical scrollbar. This has been fixed by reverting to overflow:auto. BUG=638527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/506120dfef1cb077f9dca8abe6a2eb7c6f6c6d2a Cr-Commit-Position: refs/heads/master@{#414273}

Patch Set 1 #

Patch Set 2 : overflow:auto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.html View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
calamity
4 years, 4 months ago (2016-08-23 05:25:25 UTC) #3
tsergeant
I don't think we can do this -- horizontal scrollbars are necessary to use the ...
4 years, 4 months ago (2016-08-23 05:44:45 UTC) #4
calamity
On 2016/08/23 05:44:45, tsergeant wrote: > I don't think we can do this -- horizontal ...
4 years, 4 months ago (2016-08-23 07:28:33 UTC) #5
tsergeant
On 2016/08/23 07:28:33, calamity wrote: > On 2016/08/23 05:44:45, tsergeant wrote: > > I don't ...
4 years, 4 months ago (2016-08-23 07:51:25 UTC) #6
calamity
Done.
4 years, 4 months ago (2016-08-24 02:57:26 UTC) #7
tsergeant
lgtm but maybe update the CL description
4 years, 4 months ago (2016-08-24 04:08:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2273523002/20001
4 years, 3 months ago (2016-08-25 01:00:50 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-25 02:37:27 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 02:39:34 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/506120dfef1cb077f9dca8abe6a2eb7c6f6c6d2a
Cr-Commit-Position: refs/heads/master@{#414273}

Powered by Google App Engine
This is Rietveld 408576698