[MD History] Make sidebar menu respond to spacebar.

[MD History] Make sidebar menu respond to spacebar.

This CL allows the menu items in the sidebar to be activated by the
spacebar.

BUG=639288
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b
Cr-Commit-Position: refs/heads/master@{#414034}

[calamity, 2016-08-22 03:42:58]

Description was changed from

==========
[MD History] Make sidebar menu respond to spacebar.

This CL allows the menu items in the sidebar to be activated by the
spacebar.

BUG=639288
==========

to

==========
[MD History] Make sidebar menu respond to spacebar.

This CL allows the menu items in the sidebar to be activated by the
spacebar.

BUG=639288
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-08-22 03:43:35]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 03:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 03:46:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 03:46:31]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2016-08-23 04:55:15]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 04:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 04:57:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 04:57:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[calamity, 2016-08-23 05:25:16]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[calamity, 2016-08-23 05:25:17]

I give up on rebasing this until later >_>

[tsergeant, 2016-08-23 05:41:17]

You probably could use IronA11yKeysBehavior here, but I'll leave it up to you.

https://codereview.chromium.org/2264933002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/2264933002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.js:24: * @private
Nit: @param annotation

[calamity, 2016-08-24 03:18:18]

Patchset #3 (id:40001) has been deleted

[calamity, 2016-08-24 03:57:43]

https://codereview.chromium.org/2264933002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/2264933002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.js:24: * @private
On 2016/08/23 05:41:17, tsergeant wrote:
> Nit: @param annotation

Done.

[tsergeant, 2016-08-24 04:05:41]

lgtm % nit

https://codereview.chromium.org/2264933002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/2264933002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.html:2: <link rel="import"
href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11y-keys.html">
Directly import v1_0/iron-a11y-keys-behavior/iron-a11y-keys-behavior.html here
to avoid pulling the element form into crisper.js

[calamity, 2016-08-24 05:16:07]

https://codereview.chromium.org/2264933002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/2264933002/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/side_bar.html:2: <link rel="import"
href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11y-keys.html">
On 2016/08/24 04:05:41, tsergeant wrote:
> Directly import v1_0/iron-a11y-keys-behavior/iron-a11y-keys-behavior.html here
> to avoid pulling the element form into crisper.js

Done.

[calamity, 2016-08-24 05:18:43]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 05:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 08:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 08:10:51]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tsergeant, 2016-08-24 08:49:02]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-08-24 08:49:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2264933002/#ps100001
(title: "update_closure")

[commit-bot: I haz the power, 2016-08-24 08:49:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 10:02:55]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-24 10:04:17]

Description was changed from

==========
[MD History] Make sidebar menu respond to spacebar.

This CL allows the menu items in the sidebar to be activated by the
spacebar.

BUG=639288
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Make sidebar menu respond to spacebar.

This CL allows the menu items in the sidebar to be activated by the
spacebar.

BUG=639288
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b
Cr-Commit-Position: refs/heads/master@{#414034}
==========

[commit-bot: I haz the power, 2016-08-24 10:04:18]

Patchset 5 (id:??) landed as
https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b
Cr-Commit-Position: refs/heads/master@{#414034}