Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2273463002: vm-service: Reduce copying involved in sending binary events (e.g., heap snapshot). (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

vm-service: Reduce copying involved in sending binary events (e.g., heap snapshot). Issue #27092 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/cdb7b03ee08972850e83efbcb7f2c3ae304050f1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -51 lines) Patch
M runtime/vm/service.h View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/service.cc View 3 chunks +65 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-23 00:53:04 UTC) #2
Florian Schneider
Lgtm
4 years, 4 months ago (2016-08-23 01:06:53 UTC) #3
rmacnak
4 years, 4 months ago (2016-08-23 17:02:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cdb7b03ee08972850e83efbcb7f2c3ae304050f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698